Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ] [scala-akka-http-server] Improve handling of pekko versions #20275

Closed
bjolletz opened this issue Dec 9, 2024 · 1 comment
Closed

[REQ] [scala-akka-http-server] Improve handling of pekko versions #20275

bjolletz opened this issue Dec 9, 2024 · 1 comment

Comments

@bjolletz
Copy link
Contributor

bjolletz commented Dec 9, 2024

Is your feature request related to a problem? Please describe.

In the scala-akka-http-server generator, there's an option for using pekko packages instead of akka (useApachePekko). Using this option however, versions of the pekko packages (pekko-stream, pekko-http) are hard-coded to version 1.0.0 without any possibility for a user to alter these versions. These versions are actually not even compatible since pekko-http seems to require pekko-stream >= 1.0.1 to even work.

Describe the solution you'd like

I suggest that pekko versions are handled in the same way as akka versions. This means that:

  • The version of pekko-stream is hard-coded (just like akka-stream). The current version is 1.0.3 and I suggest this version is used.
  • The version of pekko-http is managed by a paramater (just like akka-http). This means that a new parameter would be added for the scala-akka-http-server generator: pekkoHttpVersion

Describe alternatives you've considered

An alternative would be to keep hard-coding the default pekko versions, but increasing these versions to versions that actually work. Most probably the latest versions.

Additional context

None

@bjolletz
Copy link
Contributor Author

Solved in #20277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant