-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java] Remove bean validation annotations on builder #19580
base: master
Are you sure you want to change the base?
[Java] Remove bean validation annotations on builder #19580
Conversation
Make JAX-RS spec BuilderImpl class final again
…n-validation-annotations-on-builder
…annotations-on-builder
…annotations-on-builder
…n-validation-annotations-on-builder
Could anyone have a look at this PR please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jpraet, thanks for the PR!
Did you test locally if your changes fix the errors you reported and allow you to successfully run the generated code in JBoss EAP 7.4?
modules/openapi-generator/src/main/java/org/openapitools/codegen/CodegenProperty.java
Outdated
Show resolved
Hide resolved
…n-validation-annotations-on-builder
Yes I tested the changes locally. I will apply your suggested refactoring and test again. |
@wing328 could this be considered for inclusion in 7.11.0? |
@jpraet let me review and merge if no question/feedback from me have a nice weekend |
Fixes #19188 and reverts #18724.
Generated builder classes should not contain bean validation annotations.
They are unnecessary and cause problems on some Java EE servers (e.g. JBoss EAP).
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)