Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Remove bean validation annotations on builder #19580

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

jpraet
Copy link
Contributor

@jpraet jpraet commented Sep 14, 2024

Fixes #19188 and reverts #18724.

Generated builder classes should not contain bean validation annotations.
They are unnecessary and cause problems on some Java EE servers (e.g. JBoss EAP).

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jpraet jpraet changed the title Remove bean validation annotations on builder [Java] Remove bean validation annotations on builder Nov 26, 2024
@jpraet
Copy link
Contributor Author

jpraet commented Nov 26, 2024

Could anyone have a look at this PR please?

Copy link
Contributor

@martin-mfg martin-mfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jpraet, thanks for the PR!
Did you test locally if your changes fix the errors you reported and allow you to successfully run the generated code in JBoss EAP 7.4?

@jpraet
Copy link
Contributor Author

jpraet commented Dec 6, 2024

Hi @jpraet, thanks for the PR! Did you test locally if your changes fix the errors you reported and allow you to successfully run the generated code in JBoss EAP 7.4?

Yes I tested the changes locally. I will apply your suggested refactoring and test again.

@jpraet jpraet requested a review from martin-mfg December 7, 2024 10:45
@jpraet
Copy link
Contributor Author

jpraet commented Jan 3, 2025

@wing328 could this be considered for inclusion in 7.11.0?

@wing328
Copy link
Member

wing328 commented Jan 3, 2025

@jpraet let me review and merge if no question/feedback from me

have a nice weekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] @Valid TYPE_USE bean validation annotation on builder causes issues on JBoss EAP 7.4
3 participants