Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Make JAX-RS BuilderImpl class non-final to fix WELD-001503 issue #18724

Merged
merged 1 commit into from
May 26, 2024

Conversation

jpraet
Copy link
Contributor

@jpraet jpraet commented May 21, 2024

Fixes #17875

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jpraet jpraet changed the title Make JAX-RS BuilderImpl class non-final to fix WELD-001503 issue [Java] Make JAX-RS BuilderImpl class non-final to fix WELD-001503 issue May 21, 2024
@wing328 wing328 added this to the 7.7.0 milestone May 26, 2024
@wing328
Copy link
Member

wing328 commented May 26, 2024

thanks for the PR. lgtm.

let's give it a try

@wing328 wing328 merged commit 6a9b100 into OpenAPITools:master May 26, 2024
33 of 35 checks passed
jpraet added a commit to jpraet/openapi-generator that referenced this pull request Sep 14, 2024
Make JAX-RS spec BuilderImpl class final again
wing328 pushed a commit that referenced this pull request Jan 7, 2025
* Revert #18724

Make JAX-RS spec BuilderImpl class final again

* Remove bean validation annotations from builder

* Also update other java generators

* Introduce removeAnnotations lambda

* Undo import changes to JavaHelidonClientCodegen

* Add javadoc comment, examples and test for AbstractJavaCodegen.removeAnnotations()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] @Valid TYPE_USE bean validation annotation on builder causes issues on JBoss EAP 7.4
2 participants