Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test (JAVA SPRING RESTCLIENT) 18522: Add more JDK 17echo api tests & fix triggers #19189

Merged

Conversation

Nicklas2751
Copy link
Contributor

This change was missing in the #19145 PR

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@martin-mfg @wing328

@Nicklas2751 Nicklas2751 requested a review from jimschubert as a code owner July 17, 2024 13:46
@Nicklas2751 Nicklas2751 force-pushed the feature/spring-restclient-more-tests branch from 4ec7671 to 30f78f4 Compare July 17, 2024 13:48
@wing328 wing328 merged commit 75cbebd into OpenAPITools:master Jul 18, 2024
15 checks passed
@Nicklas2751 Nicklas2751 deleted the feature/spring-restclient-more-tests branch July 19, 2024 09:04
@wing328 wing328 added this to the 7.8.0 milestone Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants