Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test (JAVA SPRING RESTCLIENT) Add echo tests for the Spring 6 RestClient #19145

Merged

Conversation

Nicklas2751
Copy link
Contributor

I added the Spring 6 RestClient to the Readme and implemented some of the echo tests for it.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@cachescrubber @welshm @MelleD @atextor @manedev79 @javisst @borsch @banlevente @Zomzog @martin-mfg

@Nicklas2751
Copy link
Contributor Author

@wing328 Im sorry, but I don't understand what I should do/change. 😅

@wing328
Copy link
Member

wing328 commented Jul 14, 2024

for example, in https://github.com/OpenAPITools/openapi-generator/blob/master/.github/workflows/samples-java-client-echo-api-jdk8.yaml,

add the new folder path to line 10, 16 and 30

that way, the github workflow will run when there are changes to the new folder path

@Nicklas2751 Nicklas2751 requested a review from jimschubert as a code owner July 16, 2024 18:37
@Nicklas2751 Nicklas2751 force-pushed the feature/spring-restclient-more-tests branch from 67d45c5 to 1e8966e Compare July 16, 2024 19:17
@Nicklas2751
Copy link
Contributor Author

@wing328 I added the other clients to the JDK 17 tests but I can't add the Spring 6 RestClient tests to the JDK 8 or 11 echo api tests because the minimal version of the Spring RestClient is JDK 17.

import org.springframework.http.converter.HttpMessageConverter;
import org.springframework.http.converter.json.MappingJackson2HttpMessageConverter;
import org.springframework.http.converter.HttpMessageConverter;
import org.springframework.http.converter.json.MappingJackson2HttpMessageConverter;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for improving the code format

@wing328 wing328 merged commit 3dc3ee0 into OpenAPITools:master Jul 17, 2024
142 of 143 checks passed
@wing328 wing328 added this to the 7.8.0 milestone Jul 17, 2024
@martin-mfg
Copy link
Contributor

Hi @Nicklas2751 and @wing328, it looks like this PR did not make any changes in https://github.com/OpenAPITools/openapi-generator/blob/master/.github/workflows/ , even though you discussed this. Is this intended?

@Nicklas2751
Copy link
Contributor Author

Nicklas2751 commented Jul 17, 2024

Hi @Nicklas2751 and @wing328, it looks like this PR did not make any changes in https://github.com/OpenAPITools/openapi-generator/blob/master/.github/workflows/ , even though you discussed this. Is this intended?

Oh yes you are right there is a commit missing. Thanks for watching out.

Since this PR is closed I created a new one with the missing change: #19189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants