-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test (JAVA SPRING RESTCLIENT) Add echo tests for the Spring 6 RestClient #19145
test (JAVA SPRING RESTCLIENT) Add echo tests for the Spring 6 RestClient #19145
Conversation
…rm object response string test
…ponse string test
…tClient with fixed import indentation
@wing328 Im sorry, but I don't understand what I should do/change. 😅 |
for example, in add the new folder path to line 10, 16 and 30 that way, the github workflow will run when there are changes to the new folder path |
67d45c5
to
1e8966e
Compare
@wing328 I added the other clients to the JDK 17 tests but I can't add the Spring 6 RestClient tests to the JDK 8 or 11 echo api tests because the minimal version of the Spring RestClient is JDK 17. |
import org.springframework.http.converter.HttpMessageConverter; | ||
import org.springframework.http.converter.json.MappingJackson2HttpMessageConverter; | ||
import org.springframework.http.converter.HttpMessageConverter; | ||
import org.springframework.http.converter.json.MappingJackson2HttpMessageConverter; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for improving the code format
Hi @Nicklas2751 and @wing328, it looks like this PR did not make any changes in https://github.com/OpenAPITools/openapi-generator/blob/master/.github/workflows/ , even though you discussed this. Is this intended? |
Oh yes you are right there is a commit missing. Thanks for watching out. Since this PR is closed I created a new one with the missing change: #19189 |
I added the Spring 6 RestClient to the Readme and implemented some of the echo tests for it.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)@cachescrubber @welshm @MelleD @atextor @manedev79 @javisst @borsch @banlevente @Zomzog @martin-mfg