Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] add float to reserved word list #16689

Merged
merged 8 commits into from
Oct 1, 2023
Merged

[Python] add float to reserved word list #16689

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7bf2457
add float as reserved world
wing328 Sep 30, 2023
5433fa4
clean up
wing328 Sep 30, 2023
cda97eb
update samples
wing328 Sep 30, 2023
c01ae23
Update modules/openapi-generator/src/main/java/org/openapitools/codeg…
wing328 Oct 1, 2023
fb385e0
Merge remote-tracking branch 'origin/master' into python-float2
wing328 Oct 1, 2023
a5ca4dd
Merge branch 'python-float2' of https://github.com/OpenAPITools/opena…
wing328 Oct 1, 2023
3bf6683
update doc
wing328 Oct 1, 2023
e0f2e5a
uncomment test
wing328 Oct 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/configs/python-echo-api.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
generatorName: python
outputDir: samples/client/echo_api/python
inputSpec: modules/openapi-generator/src/test/resources/3_0/python/echo_api.yaml
inputSpec: modules/openapi-generator/src/test/resources/3_0/echo_api.yaml
templateDir: modules/openapi-generator/src/main/resources/python
additionalProperties:
hideGenerationTimestamp: "true"
3 changes: 3 additions & 0 deletions ...api-generator/src/main/java/org/openapitools/codegen/languages/AbstractPythonCodegen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,9 @@ public AbstractPythonCodegen() {
"header_params", "form_params", "local_var_files", "body_params", "auth_settings",
// @property
"property",
// pydantic keyword
wing328 marked this conversation as resolved.
Show resolved Hide resolved
"schema", "base64", "json",
"date", "float",
// python reserved words
"and", "del", "from", "not", "while", "as", "elif", "global", "or", "with",
"assert", "else", "if", "pass", "yield", "break", "except", "import",
Expand Down
15 changes: 0 additions & 15 deletions ...enapi-generator/src/main/java/org/openapitools/codegen/languages/PythonClientCodegen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,21 +130,6 @@ public PythonClientCodegen() {
// default HIDE_GENERATION_TIMESTAMP to true
hideGenerationTimestamp = Boolean.TRUE;

// from https://docs.python.org/3/reference/lexical_analysis.html#keywords
setReservedWordsLowerCase(
Arrays.asList(
// pydantic keyword
"schema", "base64", "json",
"date",
// @property
"property",
// python reserved words
"and", "del", "from", "not", "while", "as", "elif", "global", "or", "with",
"assert", "else", "if", "pass", "yield", "break", "except", "import",
"print", "class", "exec", "in", "raise", "continue", "finally", "is",
"return", "def", "for", "lambda", "try", "self", "nonlocal", "None", "True",
"False", "async", "await"));

cliOptions.clear();
cliOptions.add(new CliOption(CodegenConstants.PACKAGE_NAME, "python package name (convention: snake_case).")
.defaultValue("openapi_client"));
Expand Down
Loading