-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python] add float
to reserved word list
#16689
Conversation
@multani I've filed this change to fix the |
Ah, very nice! 👍 Note that generally speaking, it's bit more complicated: if you have a field named after anything on the right hand side of the typing information (like I haven't checked all the generator, so perhaps it lower case all the field names and it's less likely to create a problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, except for the caveats / limitations I mentioned. I don't think they are new though :)
...penapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractPythonCodegen.java
Outdated
Show resolved
Hide resolved
…en/languages/AbstractPythonCodegen.java Co-authored-by: Jonathan Ballet <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* add float as reserved world * clean up * update samples * Update modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractPythonCodegen.java Co-authored-by: Jonathan Ballet <[email protected]> * update doc * uncomment test --------- Co-authored-by: Jonathan Ballet <[email protected]>
float
to reserved word listPR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)