Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] add float to reserved word list #16689

Merged
merged 8 commits into from
Oct 1, 2023
Merged

[Python] add float to reserved word list #16689

merged 8 commits into from
Oct 1, 2023

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Sep 30, 2023

  • add float to reserved word list
  • update tests

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member Author

wing328 commented Sep 30, 2023

@multani I've filed this change to fix the float property issue. Please review when you've time.

@multani
Copy link
Contributor

multani commented Sep 30, 2023

@multani I've filed this change to fix the float property issue. Please review when you've time.

Ah, very nice! 👍

Note that generally speaking, it's bit more complicated: if you have a field named after anything on the right hand side of the typing information (like Annotated, Field, List, or anything like this), this would fail the same way.

I haven't checked all the generator, so perhaps it lower case all the field names and it's less likely to create a problem.

Copy link
Contributor

@multani multani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, except for the caveats / limitations I mentioned. I don't think they are new though :)

@wing328 wing328 added this to the 7.1.0 milestone Sep 30, 2023
Copy link
Contributor

@multani multani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wing328 Can you also uncomment

# TODO: pydantic v2: this field name override the default `float` type
#float:
#type: number
#format: float
#maximum: 987.6
#minimum: 54.3
?

You fix should address this TODO as well 👍

@wing328 wing328 marked this pull request as ready for review October 1, 2023 11:13
@wing328 wing328 merged commit ce4b2fe into master Oct 1, 2023
42 checks passed
@wing328 wing328 deleted the python-float2 branch October 1, 2023 12:41
AlanCitrix pushed a commit to AlanCitrix/openapi-generator that referenced this pull request Oct 26, 2023
* add float as reserved world

* clean up

* update samples

* Update modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractPythonCodegen.java

Co-authored-by: Jonathan Ballet <[email protected]>

* update doc

* uncomment test

---------

Co-authored-by: Jonathan Ballet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants