Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python-pydantic-v1] various improvements #16658

Merged
merged 7 commits into from
Sep 25, 2023
Merged

[python-pydantic-v1] various improvements #16658

merged 7 commits into from
Sep 25, 2023

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Sep 25, 2023 •
edited
Loading

  • copy tests from python client generator
  • add tests in circleci

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh ./bin/configs/*.yaml
./bin/utils/export_docs_generators.sh
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 mentioned this pull request Sep 25, 2023
Merged
5 tasks
@wing328
Copy link
Member Author

wing328 commented Sep 25, 2023

FYI @taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @arun-nalla (2019/11) @krjakbrjak (2023/02) @multani @fa0311

@wing328 wing328 marked this pull request as ready for review September 25, 2023 06:55
@multani
Copy link
Contributor

multani commented Sep 25, 2023

@wing328 Just for the reference, why are you removing the aiohttp client from this generator?

@wing328
Copy link
Member Author

wing328 commented Sep 25, 2023

@multani I'll revert the change. This kinda forces "aiohttp" users to use pydantic v2 in python client generator but that's not a smooth migration path for our users

@wing328 wing328 added this to the 7.1.0 milestone Sep 25, 2023
multani
multani approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@multani multani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CircleCI error seems unrelated

@wing328 wing328 merged commit 077744a into master Sep 25, 2023
39 checks passed
@wing328 wing328 deleted the python-pydantic-v1-improve branch September 25, 2023 07:59
AlanCitrix pushed a commit to AlanCitrix/openapi-generator that referenced this pull request Oct 26, 2023
@wing328 @AlanCitrix
[python-pydantic-v1] various improvements (OpenAPITools#16658)
b837cb5 
* rename, add tests

* remove library support in python pydantic v1 codegen

* copy tests

* copy echo api tests

* update samples

* update doc

* add back library support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@multani multani multani approved these changes

Assignees
No one assigned
Labels
Client: Python Enhancement: General
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wing328 @multani