Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: copy the current Python generator into a "pydantic v1" generator #16656

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

multani
Copy link
Contributor

@multani multani commented Sep 24, 2023

This generator will be deprecated over time and the normal generator will focus on Pydantic v2.

@wing328 this is the fork we discussed
@krjakbrjak

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@multani multani force-pushed the fork-pydantic-v2 branch 2 times, most recently from 81d7ad2 to 82ed87d Compare September 24, 2023 18:43
@multani multani changed the title Copy the current Python generator into a "pydantic v1" generator python: copy the current Python generator into a "pydantic v1" generator Sep 24, 2023
This generator will be deprecated over time and the normal generator will
focus on Pydantic v2.
@multani multani marked this pull request as ready for review September 24, 2023 19:17
@wing328
Copy link
Member

wing328 commented Sep 25, 2023

thanks for the PR.

  • we will need to decouple abstract python codegen as well (which currently holds a lot of pydantic-related code)
  • I'll copy the tests (petstore integration tests) into the new folder as well and update the CI to ensure pydantic v1 related samples are still tested as part of the CI workflow.
  • I'll copy the unit tests of python client generator to the new one for pydantic v1

I'll merge this one first and file a new one for the above.

@wing328
Copy link
Member

wing328 commented Sep 25, 2023

FYI @fa0311 @taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @arun-nalla (2019/11) @krjakbrjak (2023/02)

@wing328 wing328 merged commit 3b95f70 into OpenAPITools:master Sep 25, 2023
31 checks passed
@wing328
Copy link
Member

wing328 commented Sep 25, 2023

UPDATE: filed a follow-up PR #16658

@multani multani deleted the fork-pydantic-v2 branch September 25, 2023 05:46
@wing328 wing328 added this to the 7.1.0 milestone Sep 25, 2023
AlanCitrix pushed a commit to AlanCitrix/openapi-generator that referenced this pull request Oct 26, 2023
…tor (OpenAPITools#16656)

* Copy the current Python generator into a "pydantic v1" generator

This generator will be deprecated over time and the normal generator will
focus on Pydantic v2.

* add missing doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants