Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add - Status colors in Wiki, Example per parameter #12394

Merged
merged 1 commit into from
May 21, 2022

Conversation

chatelao
Copy link
Contributor

@chatelao chatelao commented May 18, 2022

This are small (but visually nice) improvements:

  • Add colors: 200 = green, 300 = blue, 400 = red
  • Add an example per parameter for better understanding

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request: @jhitchcock

This are small (but visually nice) improvements:
- Add colors: 200 = green, 300 = blue, 400 = red
- Add an example per parameter for better understanding
@wing328
Copy link
Member

wing328 commented May 21, 2022

LGMT. Thanks for the PR.

@wing328 wing328 merged commit 11462e7 into OpenAPITools:master May 21, 2022
@wing328 wing328 added Enhancement: General Doc: Cwiki Generation of Cwiki documentation labels May 21, 2022
@wing328 wing328 added this to the 6.0.0 milestone May 21, 2022
@wing328
Copy link
Member

wing328 commented May 21, 2022

FYI. Updated cwiki petstore samples via 4cf66a4

samuelo added a commit to Capitolis/openapi-generator that referenced this pull request May 22, 2022
* master:
  update gson to newer version in kotlin templates (OpenAPITools#12425)
  update gson to 2.8.9 in android httpclient (OpenAPITools#12423)
  update android dependencies to newer versions (OpenAPITools#12421)
  [Java] Update rest-assured dependencies (OpenAPITools#12420)
  update cwiki samples
  Add - Status colors in Wiki, Example per parameter (OpenAPITools#12394)
  Better support for inline schemas in parameters (OpenAPITools#12369)
  Upgrade Spring Boot to 2.5.14 / 2.7.0 (OpenAPITools#12408)
  update java samples
  Remove javadoc comment for unthrown IOException (OpenAPITools#12401)
  remove errorObjectSubtype from java client genreator (OpenAPITools#12405)
  [java][Micronaut] generator fixes (OpenAPITools#11803)
  Apply style and explode values from encoding for form-encoded request body parameters (OpenAPITools#12162)
@wing328
Copy link
Member

wing328 commented May 28, 2022

Thanks again for the PR, which has been included in the v6.0.0 release: https://twitter.com/oas_generator/status/1529669733934841856

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Doc: Cwiki Generation of Cwiki documentation Enhancement: General
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants