Apply style and explode values from encoding for form-encoded request body parameters #12162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
style
andexplode
values on theencoding
object onto request body parameters that are submitted asapplication/x-www-form-urlencoded
ormultipart
.The Encoding Object allows the specification of
style
andexplode
similar to how they can be applied to operationparameter
s.There has already existed code that would apply
contentType
from this Encoding Object, but this was the only value that was being applied. This PR renames that function fromsetParameterContentType
tosetParameterEncodingValues
, and now also appliesstyle
andexplode
as appropriate.I've added tests to
DefaultCodegenTest.testRequestBodyContent()
against some new definitions inresources/3_0/content-data.yaml
to show that these work.This should fix issues such as #3781 and #11256.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.