Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kotlin-spring] add springdoc config #12377

Merged

Conversation

sjoblomj
Copy link
Contributor

This is the Kotlin-spring version of the work @bluenick2k17 did in #12346, related to the issue reported in #12220. As @cachescrubber put it, "this is definitely [needed] to get the springdoc migration feature complete"

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@cachescrubber @jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m @wing328

@sjoblomj sjoblomj force-pushed the kotlin-spring-add-springdoc-config branch from 9fbeed8 to b1dc03f Compare May 17, 2022 15:22
@sjoblomj
Copy link
Contributor Author

@wing328 I see that version 6.0.0 was supposed to be released yesterday. Any chance of getting this merged, so that Kotlin Spring offers complete springdoc support in the next version? Or is there something I should change or fix in the PR?

All the best, and thank you for your hard unceasing work!

@sjoblomj sjoblomj mentioned this pull request May 25, 2022
4 tasks
@wing328 wing328 added this to the 6.0.0 milestone May 26, 2022
@wing328 wing328 merged commit 770c1cb into OpenAPITools:master May 26, 2022
@wing328
Copy link
Member

wing328 commented May 26, 2022

Merged. Thanks for the PR.

@wing328
Copy link
Member

wing328 commented May 28, 2022

Thanks again for the PR, which has been included in the v6.0.0 release: https://twitter.com/oas_generator/status/1529669733934841856

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants