-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java][spring] added springdoc support for service metadata and security #12346
Merged
wing328
merged 13 commits into
OpenAPITools:master
from
StateFarmIns:spring-add-springdoc-config
May 18, 2022
Merged
[java][spring] added springdoc support for service metadata and security #12346
wing328
merged 13 commits into
OpenAPITools:master
from
StateFarmIns:spring-add-springdoc-config
May 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caveat: didn't add oauth2 flows
and added springdoc test
implemented through booleans in template instead
removed if and fixed escaping
bluenick2k17
changed the title
Spring add springdoc config
[java][spring] added springdoc support for service metadata and security
May 13, 2022
borsch
approved these changes
May 13, 2022
welshm
approved these changes
May 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this!
.../openapi-generator/src/test/java/org/openapitools/codegen/java/spring/SpringCodegenTest.java
Show resolved
Hide resolved
welshm
approved these changes
May 13, 2022
.../openapi-generator/src/test/java/org/openapitools/codegen/java/spring/SpringCodegenTest.java
Show resolved
Hide resolved
welshm
approved these changes
May 13, 2022
.../openapi-generator/src/test/java/org/openapitools/codegen/java/spring/SpringCodegenTest.java
Show resolved
Hide resolved
cachescrubber
approved these changes
May 16, 2022
4 tasks
Thanks again for the PR, which has been included in the v6.0.0 release: https://twitter.com/oas_generator/status/1529669733934841856 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpringCodegen
to add the new documentation config file (SpringDocConfiguration.java
) to the list of auto-generated filesspringdocDocumentationProvider.mustache
for the Spring generator which buildsSpringDocConfiguration.java
target/generated-sources/openapi/src/main/java/org/openapitools/configuration/SpringDocConfiguration.java
in the resulting API.CodegenSecurityTest
was updated to test the new addition of the SpringDoc configuration, and test was cleaned up to reduce duplication when adding the additional documentation provider test.SpringCodegen
which still used Springfox verbiage, even though the default documentation provider is springdoc.Some notes on the implementation:
CodegenSecurity
doesn't support a description field yet for the auth method, so as of now that support remains the sameCloses #12220
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
@cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02)