Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spring] Fixes #10878 - fixed dates in pathParam #10879

Closed
wants to merge 3 commits into from

Conversation

jameswynn
Copy link
Contributor

@jameswynn jameswynn commented Nov 17, 2021

Fixes #10878

This fixes how dates are serialized in JavaSpring's pathParam template by applying the same configuration as used by the queryParam template. With this change dates in the path will be serialized by Feign clients in correct RFC3339 notation (YYYY-MM-DD).

@cbornet

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jameswynn
Copy link
Contributor Author

#10878

@jameswynn jameswynn changed the title Fixes #10878 - added date handling in JavaSpring's pathParam template [JavaSpring] Fixes #10878 - fixed dates in pathParam Nov 17, 2021
@jameswynn jameswynn changed the title [JavaSpring] Fixes #10878 - fixed dates in pathParam [spring] Fixes #10878 - fixed dates in pathParam Nov 17, 2021
@jameswynn
Copy link
Contributor Author

@wing328
Copy link
Member

wing328 commented Jan 2, 2022

Closed via #11181. Please pull the latest master to give it a try.

@wing328 wing328 closed this Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][java] JavaSpring Date PathParams serialize in the wrong format in
4 participants