Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][java] JavaSpring Date PathParams serialize in the wrong format in #10878

Open
5 of 6 tasks
jameswynn opened this issue Nov 17, 2021 · 0 comments
Open
5 of 6 tasks

Comments

@jameswynn
Copy link
Contributor

Bug Report Checklist

  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Sponsorship to speed up the bug fix or feature request (example)
Description

Date parameters in the path should be serialized according to RFC3339 (YYYY-MM-DD) but are actually serialized as M/D/YY. This was already addressed in the queryParams template by specifying a DateTimeFormat. The same logic should be used in the pathParams template.

openapi-generator version

Using OpenAPI Generator 5.3.0

OpenAPI declaration file content or url
components:
  parameters:
    MyDateParam:
      name: myDate
      in: path
      required: true
      type: string
      format: date
Generation Details

Using the following settings:

  • module: JavaSpring
  • library: spring-cloud
  • dateLibrary: java8
Steps to reproduce

Serialize a pathParam date using a Feign client. The resulting path will contain an incorrect date.

Suggest a fix

The same issue was already addressed in the queryParams template. Applying it to the pathParams template resolves the issue. I'll submit a PR shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant