Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #22 C# gha workflow #143

Merged
merged 54 commits into from
May 13, 2024
Merged

Fixes #22 C# gha workflow #143

merged 54 commits into from
May 13, 2024

Conversation

Felixmil
Copy link
Collaborator

@Felixmil Felixmil commented Apr 25, 2024 •
edited by rwmcintosh
Loading

Fixes #22

image

Felixmil and others added 30 commits April 25, 2024 09:15
@Felixmil
temporarly disable R workflows
403455a
@Felixmil
add draft workflow for building/testing/commiting binaries
011638b
@Felixmil
fix name
209b1d0
@Felixmil
fix yaml
f7407f5
@Felixmil
fix yaml (again)
004208b
@Felixmil
make linux-build job starting only after windows-build job is completed
db0f2ae
@Felixmil
modified checkout step
61eb981 
according to this: https://github.com/marketplace/actions/add-commit#working-with-prs
@rwmcintosh
try nuget
0253247
@rwmcintosh
add packagesdirectory
b9f2696
@rwmcintosh
update dotnet sdk
683e07f
@rwmcintosh
update build and test
8ee2075
@rwmcintosh
c++ cannot build using dotnet build
7539c76
@rwmcintosh
try setting path
76242ef
@rwmcintosh
try setting path
bd6f79c
@rwmcintosh
use enterprise
c474ca8
@rwmcintosh
use msbuild instead
1af038a
@rwmcintosh
not diagnostic
bbedacd
@rwmcintosh
setup R
5e1a67f
@rwmcintosh
change r path
518a9fe
@rwmcintosh
change r path
7af6d59
@rwmcintosh
log test crash
180a328
@rwmcintosh
skip failing test
8ebe2b0
@rwmcintosh
skip build when testing
b1a6cb1
@rwmcintosh
specify test projects
95d8e7b
@rwmcintosh
test release builds
62b6922
@rwmcintosh
try another assembly test
fa3ed65
@github-actions
Commit from GitHub Actions (build-c#-binaries)
11c9c1a
@rwmcintosh
try linux build
897bfe0
@rwmcintosh
Merge branch 'C#-gha-workflow' of github.com:Open-Systems-Pharmacolog…
0ba8702 
…y/RSharp into C#-gha-workflow
@rwmcintosh
try linux build
938e0bd
@rwmcintosh rwmcintosh requested a review from PavelBal May 9, 2024 20:12
@rwmcintosh
Copy link
Member

I think we have to be observant about this. I believe the tests are not very reliable, but let's start with this.

@rwmcintosh
Copy link
Member

Fixes #22

@rwmcintosh rwmcintosh linked an issue May 9, 2024 that may be closed by this pull request
Set up continuous integration for C++ and C# #22
Closed
@rwmcintosh rwmcintosh changed the title C# gha workflow Fixes #22 C# gha workflow May 9, 2024
Felixmil
Felixmil commented May 13, 2024
View reviewed changes
.github/workflows/R-CMD-check.yaml Outdated Show resolved Hide resolved
.github/workflows/pkgdown.yaml Outdated Show resolved Hide resolved
.github/workflows/test-coverage.yaml Outdated Show resolved Hide resolved
@Felixmil
Copy link
Collaborator Author

Felixmil commented May 13, 2024 •
edited
Loading

R actions should start only after binaries successfully built. Will only work once the C# building workflow is in default branch (cf https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_run)

Note: This event will only trigger a workflow run if the workflow file is on the default branch.

Felixmil and others added 2 commits May 13, 2024 10:27
@Felixmil
trigger R actions only after binaries were built
08e0e87 
+ trigger R actions on pull request to main branch
+ remove comments
@github-actions
Commit from GitHub Actions (build-c#-binaries)
d712174
@Felixmil
Copy link
Collaborator Author

@rwmcintosh The .so file is apparently not commited during the Linux step: https://github.com/Open-Systems-Pharmacology/rSharp/actions/runs/9059706133/job/24887856458#step:8:28

However the .dll files are commited during the Windows build: https://github.com/Open-Systems-Pharmacology/rSharp/actions/runs/9059706133/job/24887924340#step:10:32

@rwmcintosh
Copy link
Member

@rwmcintosh The .so file is apparently not commited during the Linux step: https://github.com/Open-Systems-Pharmacology/rSharp/actions/runs/9059706133/job/24887856458#step:8:28

However the .dll files are commited during the Windows build: https://github.com/Open-Systems-Pharmacology/rSharp/actions/runs/9059706133/job/24887924340#step:10:32

It could be because gcc builds the binary equivalent when source is unchanged where msvc does not. I will commit a change in the C++ cod to test it today, but then I need to change it back again before merging.

@rwmcintosh
Copy link
Member

@rwmcintosh The .so file is apparently not commited during the Linux step: https://github.com/Open-Systems-Pharmacology/rSharp/actions/runs/9059706133/job/24887856458#step:8:28
However the .dll files are commited during the Windows build: https://github.com/Open-Systems-Pharmacology/rSharp/actions/runs/9059706133/job/24887924340#step:10:32

It could be because gcc builds the binary equivalent when source is unchanged where msvc does not. I will commit a change in the C++ cod to test it today, but then I need to change it back again before merging.

@Felixmil confirmed the above. Changes in cpp source will trigger a commit of .so. All Linux and Windows build/commit is complete.

@Felixmil
Copy link
Collaborator Author

C# binaries are now built by github actions and pushed to repository (in PR branches, before merge)

@PavelBal Can we merge ?

@PavelBal
Copy link
Member

Let's try out.

@Felixmil Felixmil merged commit dc5a413 into main May 13, 2024
@Felixmil Felixmil deleted the C#-gha-workflow branch May 13, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PavelBal PavelBal PavelBal approved these changes

Assignees

@rwmcintosh rwmcintosh

@Felixmil Felixmil

Labels
None yet
Projects
No open projects
RSharp V1
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up continuous integration for C++ and C#
3 participants
@Felixmil @rwmcintosh @PavelBal