Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up continuous integration for C++ and C# #22

Closed
rwmcintosh opened this issue Feb 15, 2024 · 7 comments · Fixed by #143
Closed

Set up continuous integration for C++ and C# #22

rwmcintosh opened this issue Feb 15, 2024 · 7 comments · Fixed by #143
Assignees

Comments

@rwmcintosh
Copy link
Member

Windows and Linux

@rwmcintosh rwmcintosh moved this to Backlog in RSharp V1 Feb 21, 2024
@PavelBal
Copy link
Member

  1. Build windows C++/C# libs
  2. Build linux libs
  3. Build R package
  4. Build website

@PavelBal PavelBal moved this from Backlog to Ready in RSharp V1 Mar 12, 2024
@Felixmil
Copy link
Collaborator

Superseded by #122 ?

@PavelBal
Copy link
Member

One step at a time, we are not sure how to set up CI for C++/C# libs. First, lets have this running for R.

@rwmcintosh rwmcintosh changed the title Set up continuous integration on AppVeyor Set up continuous integration for C++ and C# Apr 9, 2024
@PavelBal
Copy link
Member

@Felixmil @Yuri05

Right now we build the C++/C# libs locally, commit the updated DLLs, and the CI (GitHub actions) only builds the R package. Is it possible to do C++/C# building also with GA?

@PavelBal
Copy link
Member

Related: #121

@Felixmil
Copy link
Collaborator

Felixmil commented Apr 16, 2024

I'm sure it is possible (cf https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-net) but I have no experience in building C++/C#. Though, I have enough experience to provide support for translating technical requirement (provided by Rob) to github actions/workflow.

@rwmcintosh
Copy link
Member Author

It's probably no problem for the .NET assemblies, but the native dll's are a different story. We need to produce a package containing rSharpUx.so and rSharpMs.dll for Ubuntu and Windows respectively. You need both OS's to build them.

@rwmcintosh rwmcintosh linked a pull request May 9, 2024 that will close this issue
@rwmcintosh rwmcintosh moved this from Ready to In review in RSharp V1 May 10, 2024
Felixmil added a commit that referenced this issue May 13, 2024
Co-authored-by: Robert McIntosh <[email protected]>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from In review to Done in RSharp V1 May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants