Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't display error bar caps when there are no error bars #348

Closed
IndrajeetPatil opened this issue Jul 26, 2022 · 2 comments
Closed

Don't display error bar caps when there are no error bars #348

IndrajeetPatil opened this issue Jul 26, 2022 · 2 comments
Labels
prio: medium

Comments

@IndrajeetPatil
Copy link
Member

IndrajeetPatil commented Jul 26, 2022 •
edited
Loading

Follow up on #344

This happens when the error values are 0, and so there is no error bar displayed. But the caps are still shown.

Look at total and Placebo_total group data points:

image
@pchelle
Copy link
Collaborator

pchelle commented Jul 26, 2022

Since dataMapping now uses ymin and ymax instead of error.
You can use NA values if there is no error so the cap won't show up.
I can add the argument na.rm=TRUE so you won't get the warning messages

IndrajeetPatil added a commit to Open-Systems-Pharmacology/OSPSuite-R that referenced this issue Jul 29, 2022
@IndrajeetPatil
no caps if no error bars
a0afb8c 
Open-Systems-Pharmacology/TLF-Library#348
@IndrajeetPatil
Copy link
Member Author

Thanks! That solved the issue.

IndrajeetPatil added a commit to Open-Systems-Pharmacology/OSPSuite-R that referenced this issue Aug 12, 2022
@IndrajeetPatil
Improvements to profile plots when multiple datasets of a given type …
b0aeb13 
…present per group (#1054)

* Profile plots for multiple datasets per group

* fix example

* change mapping only if multiple datasets per group

* Update plot-individual-time-profile.R

* no caps if no error bars

Open-Systems-Pharmacology/TLF-Library#348

* add test for multiple obs and sim datasets

* another test

* unnecessary

* fix multiple simulated datasets per group plot

* update test outputs

* use saved popsim results

Closes #1056

* reduce customization

* Add test for #1052

* remove redundant tests

* don't pass around plot config object

* Fixes scatter plots

Closes #1052
Gets rid of interpolation as specified in #804

* error bars for observed data in population profile

Closes #1059

* Add more tests for `plotPopulationTimeProfile()`

Closes #1058

* update snaps and docs

* fix tests

* Update test-plot-population-time-profile.R

* simplify population profile mapping

* correct mapping

* avoid repetition in mappings

* minor

* Update test-plot-individual-time-profile.R

* Update test-plot-individual-time-profile.R

* with CRAN ggplot2

* update snapshots

* Update test-plot-individual-time-profile.R

* Update snapshots for tlf changes

* minor

* unskip skipped tests and see if it works

* Fixes upper quantile of population profile plot

Closes #1062

* Add example

* Add examples to the manual

Closes #1065

* Exclude appveyor files

Closes #1066

* Fixes `plotPopulationTimeProfile()` mappings

Closes #1064

* docs

* minor improvements to comments and docs

* redocument

* same range for axes in scatter plots

Closes #1051

* skip for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prio: medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@IndrajeetPatil @pchelle