Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plotPopulationTimeProfile - upper quantile is not shown #1062

Closed
PavelBal opened this issue Aug 8, 2022 · 4 comments · Fixed by #1054
Closed

plotPopulationTimeProfile - upper quantile is not shown #1062

PavelBal opened this issue Aug 8, 2022 · 4 comments · Fixed by #1054
Assignees
Labels
prio: high type: bug Something isn't working

Comments

@PavelBal
Copy link
Member

PavelBal commented Aug 8, 2022

In the current version, only the mid quantile is shown as a line and the lower quantile as shaded area, the upper quantile is not presented:

simFilePath <- system.file("extdata", "Aciclovir.pkml", package = "ospsuite")
sim <- loadSimulation(simFilePath)

outputPaths <- c("Organism|PeripheralVenousBlood|Aciclovir|Plasma (Peripheral Venous Blood)",
                 "Organism|Muscle|Intracellular|Aciclovir|Concentration")

#simResults <- runSimulation(sim, population = pop)
simResults <- importResultsFromCSV(simulation = sim, filePaths = system.file("extdata", "SimResults_pop.csv", package = "ospsuite"))

myDataCombined <- DataCombined$new()
# Add simulated results
myDataCombined$addSimulationResults(simulationResults = simResults,
                                    quantitiesOrPaths = outputPaths[[1]],
                                    groups = "Aciclovir PVB")

plotPopulationTimeProfile(myDataCombined, plotConfig, quantiles = c(.2, .5, .8))

image

@PavelBal PavelBal assigned PavelBal and IndrajeetPatil and unassigned PavelBal Aug 8, 2022
@PavelBal PavelBal added type: bug Something isn't working prio: high labels Aug 8, 2022
@IndrajeetPatil
Copy link
Member

I think I know what's the problem.

@IndrajeetPatil
Copy link
Member

With #1054

library(ospsuite)

simFilePath <- system.file("extdata", "Aciclovir.pkml", package = "ospsuite")
sim <- loadSimulation(simFilePath)

outputPaths <- c(
  "Organism|PeripheralVenousBlood|Aciclovir|Plasma (Peripheral Venous Blood)",
  "Organism|Muscle|Intracellular|Aciclovir|Concentration"
)

simResults <- importResultsFromCSV(
  simulation = sim,
  filePaths = system.file("extdata", "SimResults_pop.csv", package = "ospsuite")
)

myDataCombined <- DataCombined$new()

myDataCombined$addSimulationResults(
  simulationResults = simResults,
  quantitiesOrPaths = outputPaths[[2]],
  groups = "Aciclovir PVB"
)

plotPopulationTimeProfile(myDataCombined, quantiles = c(.2, .5, .8))

Created on 2022-08-09 by the reprex package (v2.0.1.9000)

@PavelBal
Copy link
Member Author

PavelBal commented Aug 9, 2022

Ah ok, I wasn't using the latest version of the branch... My bad.

@PavelBal PavelBal closed this as completed Aug 9, 2022
@IndrajeetPatil
Copy link
Member

No, no, I meant that that PR would fix this issue 😅

@IndrajeetPatil IndrajeetPatil changed the title plotPopulationTimeProfile - upper quantile is not shown. plotPopulationTimeProfile - upper quantile is not shown Aug 9, 2022
@IndrajeetPatil IndrajeetPatil reopened this Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: high type: bug Something isn't working
Projects
None yet
2 participants