Change default value in code #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msevestre
commented
Jan 18, 2022
| @@ -35,15 +35,15 @@ public override IndividualMolecule AddMoleculeTo(ISimulationSubject simulationSu | |||
|
|
|||
| AddGlobalExpression(molecule, | |||
| RelExpParam(REL_EXP_BLOOD_CELLS), | |||
| FractionParam(FRACTION_EXPRESSED_BLOOD_CELLS, CoreConstants.Rate.ZERO_RATE), | |||
| FractionParam(FRACTION_EXPRESSED_BLOOD_CELLS, CoreConstants.Rate.ONE_RATE), | |||
There was a problem hiding this comment.
We are not using the DB For this. I would love to update that to make sure we are relying only one one source of truth. I might get a stab at it in the next PR
|
conflicts... |
|
ok no problem |
|
I need to fix in the DB as well |
msevestre
force-pushed
the
2053-default-value-fraction-expressed
branch
from
48d2c9b to
e0b4cd9
Compare
msevestre
commented
Jan 18, 2022
| @@ -54899,8 +54899,8 @@ INSERT INTO tab_container_parameter_rates VALUES(5011,'GENERAL','MoleculePropert | |||
| INSERT INTO tab_container_parameter_rates VALUES(1678,'COMPOUND','DRUG','Enable supersaturation','CompoundCommon','Zero_Rate',0.0,1,1.0,1,NULL); | |||
| INSERT INTO tab_container_parameter_rates VALUES(5015,'GENERAL','PROTEIN','Fraction expressed on tissue-side membrane of vascular endothelium','ExpressionParameters','PARAM_f_exp_vasc_tissue_side',0.0,1,1.0,1,NULL); | |||
| INSERT INTO tab_container_parameter_rates VALUES(5015,'GENERAL','PROTEIN','Fraction expressed on plasma-side membrane of vascular endothelium','ExpressionParameters','Zero_Rate',0.0,1,1.0,1,NULL); | |||
| INSERT INTO tab_container_parameter_rates VALUES(5015,'GENERAL','PROTEIN','Fraction expressed in blood cells','ExpressionParameters','Zero_Rate',0.0,1,1.0,1,NULL); | |||
| INSERT INTO tab_container_parameter_rates VALUES(5015,'GENERAL','PROTEIN','Fraction expressed in endosomes','ExpressionParameters','Zero_Rate',0.0,1,1.0,1,NULL); | |||
| INSERT INTO tab_container_parameter_rates VALUES(5015,'GENERAL','PROTEIN','Fraction expressed in blood cells','ExpressionParameters','One_Rate',0.0,1,1.0,1,NULL); | |||
There was a problem hiding this comment.
One rate here. But it's not used since it's all read from the code. I am going to tackle that tomorrow. It won't be all good, but at least we won't duplicate all info like this
Yuri05
approved these changes
Jan 18, 2022
|
Boom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to be changed in the DB but I cna't do this until we merge the Urine stuff