Default values for Fraction Expressed in Blood Cells and in Endosome not as expected

[Yuri05]

At the moment, the default values of Fraction expressed in blood cells and Fraction expressed in endosomes parameters are zero:

I think, both values should be one as per default (the expected default localization when setting a relExp value for blood cells is inside blood cells and expected default localization when adding a vasular endo relExp is inside endosomes).

But changing this would require snapshot conversion.
To be discussed.

[Yuri05]

@msevestre @PavelBal @sfrechen

[PavelBal]

Well, one of the fractions should be 1, so I think your proposal makes sense.

[Yuri05]

One of the fractions is 1 per construction, because it's defined as 1 - another fraction (for BC) or 1 - sum of another fractions (for vasc endo).
The point is: it's not the fraction you would assume to be set 1 as per default. Thus if you e.g. just set relExpBC>0: this amount will be placed in plasma as per default - unless you explicitely set Fraction expressed in blood cells to 1.
If we set Fraction expressed in blood cells to 1 and Fraction expressed in endosome to 1 when importing from GeneDB - everything will be fine in PK-Sim.
However if setting relExp_BC or relExp_VascEndo in MoBi or via the R-Toolbox: the user would need to know that the corresponding fraction expressed must be set as well.

[msevestre]

But the same is to be said if we had rel_exp plasma coming from the DB? Somehow the default only makes sense in some cases

[Yuri05]

well, relExpPlasma is always placed in plasma, so we don't have any fractions expressed here..

[msevestre]

We are already doing a project conversion for expression profile so we might as well change whatever should be changed

[StephanSchaller]

I don't get it yet. Is this a V9 vs V10 issue or a general issue?

Will chat with Pavel on this later.

[msevestre]

This is a v10 issue and not of an issue but more of a way of seeing things :)
@Yuri05 I don't think we need project conversion:
1: As soon as a value is clicked (Either BC_membrane or BC_intracellular) the underlying parameter is set automatically and appears to not have been set by the user (is_default = true)

So the json look like so

{
  "Type": "Enzyme",
  "Species": "Human",
  "Molecule": "CYP",
  "Category": "toto",
  "Localization": "Intracellular, BloodCellsIntracellular"
}

or

{
  "Type": "Enzyme",
  "Species": "Human",
  "Molecule": "CYP",
  "Category": "toto",
  "Localization": "Intracellular, BloodCellsMembrane"
}

The only issue would be when a user select BOTH locations (InBloodCells). In that case the default value of the fraction remains unchanged but this is very unlikely since the user should overwrite the value with its own ratio. In this case, the value is saved as used defined parameter

So I don't think we need project conversion but I think it make sense to set the default value as you said to one

[msevestre]

An interesting little side effects: The default value of the fraction depends on what is being clicked. I think this is fine
1: Membrane first and then intracellular

2: Intracellular first and then Membrane

[Yuri05]

The "side effect" is OK for me. If the user selects both, then the fraction expressed value between 0 and 1 must be entered manually anyway. Ofc PK-Sim could e.g. set Fraction expressed to e.g. to 0.5 in this case, but this does not make much sense.