Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.1.0 release #57

Merged
merged 12 commits into from
Feb 10, 2022
Merged

1.1.0 release #57

merged 12 commits into from
Feb 10, 2022

Conversation

IndrajeetPatil
Copy link
Member

No description provided.

msevestre and others added 12 commits February 2, 2022 12:40
@msevestre
Create develop branch
34ad62b
@IndrajeetPatil
closes #29 (#44)
8c6f1aa 
- better documentation for `isIncluded()`
- more tests
- more examples
@IndrajeetPatil
closes #29 (#45)
faa6130 
* closes #29

* if not a vector, convert to one
@IndrajeetPatil
closes #29 (#46)
b6f1104 
* closes #29

error if objects are entered as arguments

* drop purrr
@IndrajeetPatil
don't accept environments either (#47)
0572374 
just for good measure
@pchelle
Fixes #32 set a more consistent behaviour for formatNumerics (#48)
c6a86c4
@IndrajeetPatil
closes #30 (#49)
5bb5484
@IndrajeetPatil
closes #31 (#52)
c451402
@IndrajeetPatil
closes #50 (#51)
16ebd4f 
remove unnecessary lint detection
@IndrajeetPatil
closes #34 (#54)
3f4b1e1 
Separates docs for `validateIsSameLength()` from `validateIsOfLength()`
@IndrajeetPatil
closes #21; prepare for CRAN (#55)
2ca4588 
* closes #21; prepare for CRAN

* more tests with list
@IndrajeetPatil
use correct URL for codecov in README (#56)
5ba9f1d
@codecov-commenter
Copy link

Codecov Report

Merging #57 (5ba9f1d) into main (92dc5be) will increase coverage by 0.06%.
The diff coverage is 97.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   98.55%   98.61%   +0.06%     
==========================================
  Files           7        7              
  Lines         138      144       +6     
==========================================
+ Hits          136      142       +6     
  Misses          2        2
Impacted Files Coverage Δ
R/error-checks.R 97.29% <97.29%> (+0.32%) ⬆️
R/formatNumerics.R 100.00% <100.00%> (ø)
R/validation-helpers.R 98.07% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92dc5be...5ba9f1d. Read the comment docs.

@IndrajeetPatil
Copy link
Member Author

@msevestre, @PavelBal Can I merge this into main?

1.1.0 release already made it to CRAN yesterday, so the main is now lagging behind CRAN version.

@IndrajeetPatil IndrajeetPatil merged commit ab97945 into main Feb 10, 2022
@msevestre
Copy link
Member

How did you merge into main? Hopefully not using squash. As admin, great power comes with great responsibility

@IndrajeetPatil
Copy link
Member Author

Damn it. I did squash and merge. Force of habit 😞

Reverting it.

IndrajeetPatil added a commit that referenced this pull request Feb 10, 2022
@IndrajeetPatil
Revert "1.1.0 release (#57)"
d128caf 
This reverts commit ab97945.
@IndrajeetPatil IndrajeetPatil mentioned this pull request Feb 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PavelBal PavelBal PavelBal approved these changes

@msevestre msevestre Awaiting requested review from msevestre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@IndrajeetPatil @codecov-commenter @msevestre @PavelBal @pchelle