What to do with all those warnings? #50
Comments
|
They are not warnings, just notes on possible lints in the code base. On it! |
|
"Check warning" they say.... :) |
|
Ah, I see. Yeah, but that's GHA talking and we often need not concern ourselves with its warnings. The warnings we should care about are the ones in R CMD Check. At any rate, I will see if any of these lints are something we ought to be attending to or are false positives. |
|
Can we configure GHA to turn the warning off that we do not want to see / see as acceptable? Otherwise it's just noise |
|
Yes, we can do that. Will file a PR soon. |
IndrajeetPatil
added a commit
that referenced
this issue
Feb 7, 2022
Merged
IndrajeetPatil
added a commit
that referenced
this issue
Feb 10, 2022
* Create develop branch * closes #29 (#44) - better documentation for `isIncluded()` - more tests - more examples * closes #29 (#45) * closes #29 * if not a vector, convert to one * closes #29 (#46) * closes #29 error if objects are entered as arguments * drop purrr * don't accept environments either (#47) just for good measure * Fixes #32 set a more consistent behaviour for formatNumerics (#48) * closes #30 (#49) * closes #31 (#52) * closes #50 (#51) remove unnecessary lint detection * closes #34 (#54) Separates docs for `validateIsSameLength()` from `validateIsOfLength()` * closes #21; prepare for CRAN (#55) * closes #21; prepare for CRAN * more tests with list * use correct URL for codecov in README (#56) Co-authored-by: Michael Sevestre <[email protected]> Co-authored-by: Pierre Chelle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Should we check them out?
The text was updated successfully, but these errors were encountered: