Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove msui web browser #2518

Closed
wants to merge 21 commits into from
Closed

Remove msui web browser #2518

wants to merge 21 commits into from

Conversation

nilupulmanodya
Copy link
Collaborator

@nilupulmanodya nilupulmanodya commented Sep 8, 2024 •
edited
Loading

Purpose of PR?:

Fixes #
#2503

Does this PR introduce a breaking change?
No

If the changes in this PR are manually verified, list down the scenarios covered::

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Does this PR results in some Documentation changes?
If yes, include the list of Documentation changes

Checklist:

ReimarBauer and others added 21 commits May 24, 2024 09:09
@ReimarBauer
Merge pull request Open-MSS#2389 from Open-MSS/merge_stable_to_develop
20bbf55 
Merge stable to develop
@ReimarBauer
Merge branch 'stable' into merge_stable_to_develop
a650456
@ReimarBauer
Merge pull request Open-MSS#2427 from Open-MSS/merge_stable_to_develop
455718f 
Merge stable to develop
@matrss
Fix spelling of the mslib.msui.aircraft module (Open-MSS#2429)
eabc338
@ReimarBauer @workaryangupta
feat: Allow users to set custom profile pictures (Open-MSS#2405) (Ope…
6915b06 
…n-MSS#2431)

Enhancing the functionality of the MSColab server to allow users to upload small images which would replace generic initials as identifiers during login. This feature personalizes user accounts and significantly enhances the visual aspect of user identification and interaction within the MSColab platform.

Co-authored-by: Aryan Gupta <[email protected]>
@ReimarBauer
Merge branch 'stable' into merge_stable_to_develop
f814dab
@ReimarBauer
Merge pull request Open-MSS#2446 from Open-MSS/merge_stable_to_develop
2753b87 
Merge stable to develop
@matrss
Use flask-migrate for database migrations (Open-MSS#2432)
42c8f2b 
With this flask-migrate is used on application setup to automatically
migrate the configured database to the latest revision shipped with
MSColab. This will make manual migrations in production environments
unnecessary in the future.

Also included is an upgrade path from databases which were previously
manually managed. This entails generating a new database and copying
over all data.
@dependabot
Bump benc-uk/workflow-dispatch from 1.2.3 to 1.2.4 (Open-MSS#2449)
ad8e549 
Bumps [benc-uk/workflow-dispatch](https://github.com/benc-uk/workflow-dispatch) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/benc-uk/workflow-dispatch/releases)
- [Commits](benc-uk/workflow-dispatch@v1.2.3...v1.2.4)

---
updated-dependencies:
- dependency-name: benc-uk/workflow-dispatch
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@matrss
Fix sequences after migrating data to PostgreSQL (Open-MSS#2466)
da36488 
When inserting rows into PostgreSQL tables and explicitly setting values
for e.g. auto-increment columns, like the IDs, the associated sequences
aren't automatically updated. This means that without explicitly fixing
the sequences PostgreSQL would try to insert new rows with existing
values for the IDs, failing in the process due to unique constraints.

This issue doesn't affect MariaDB nor SQLite. The former automatically
updates auto-increment counters on insert, the latter simply uses the
last rows ID as a starting point.

This change also extends the tests to try adding a new user after the
migration, which should catch this kind of issue.
@matrss
Fixes for using PostgreSQL (Open-MSS#2467)
4344e00 
Created enum types should also be dropped on downgrade. Dropping tables
must be committed to become visible.
@ReimarBauer
Merge branch 'stable' into merge_stable_to_develop
641b7f2
@ReimarBauer @matrss @dependabot
Merge stable to develop (Open-MSS#2482)
2c89c79 
* removing pinned xmlschema (Open-MSS#2117)

* Stop ignoring some test files (Open-MSS#2291)

* Reconfigured tutorial videos for RTFD (Open-MSS#2458)

* changed to videos/

* use mss style on rtfd

* fix urls and text (Open-MSS#2460)

* Bump benc-uk/workflow-dispatch from 1.2.3 to 1.2.4 (Open-MSS#2450)

Bumps [benc-uk/workflow-dispatch](https://github.com/benc-uk/workflow-dispatch) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/benc-uk/workflow-dispatch/releases)
- [Commits](benc-uk/workflow-dispatch@v1.2.3...v1.2.4)

---
updated-dependencies:
- dependency-name: benc-uk/workflow-dispatch
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Limit video width to the containing block's width (Open-MSS#2463)

* pinning of libtiff is not needed but blocks a more recent libxml2 and others (Open-MSS#2469)

* fixed the model.Message description and tests now using op_id (Open-MSS#2470)

* bug fix for incomplete xml imports (Open-MSS#2468)

validate xml content

* prepare v9.2.0 (Open-MSS#2481)

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Matthias Riße <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@joernu76
Fix Open-MSS#2478 (Open-MSS#2479)
56f6c9e
@joernu76
Revert "Merge stable to develop (Open-MSS#2482)" (Open-MSS#2490)
0f294d9 
This reverts commit 2c89c79.
@ReimarBauer
Merge pull request Open-MSS#2493 from Open-MSS/merge_stable_to_develop
09afb6e 
Merge stable to develop
@joernu76
Fix Open-MSS#2476
0b95679
@ReimarBauer @workaryangupta
Gsoc2024 aryan gupta (Open-MSS#2501)
d58f5fc 
Enhancing the functionality of the MSColab server to allow users to upload small images which would replace generic initials as identifiers during login. This feature personalizes user accounts and significantly enhances the visual aspect of user identification and interaction within the MSColab platform.

This includes real-time tracking of active users per operation, enhancing the chat window, seeing who performed what changes and separating system message from user messages.


---------

Co-authored-by: Aryan Gupta <[email protected]>
@ReimarBauer @matrss
remove the conda/mamba based updater. (Open-MSS#2495)
ee9e832 
Show in About a new version available.


---------

Co-authored-by: Matthias Riße <[email protected]>
@ReimarBauer @matrss
renamed and refactored names for mscolab (Open-MSS#2499)
863f052 
removed the xmlsec binary selector based on CONDA_PREFIX
provided separate config for msidp
separate dir for mscolab server data and work asynchronously by msolab ui


---------

Co-authored-by: Matthias Riße <[email protected]>
@nilupulmanodya
fix: remove dead codes
51ac111
ReimarBauer
ReimarBauer requested changes Sep 8, 2024
View reviewed changes
Copy link
Member

@ReimarBauer ReimarBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please send the PR to stable

@nilupulmanodya nilupulmanodya changed the base branch from develop to stable September 8, 2024 15:26
ReimarBauer
ReimarBauer requested changes Sep 8, 2024
View reviewed changes
Copy link
Member

@ReimarBauer ReimarBauer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course please send your change few files only to stable, don't do a merge, which would mean a new release

You can create a patch file from your previous commit and add that to a branch copy of stable

@nilupulmanodya nilupulmanodya deleted the i2503 branch September 9, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReimarBauer ReimarBauer ReimarBauer requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

import failure in mslib.msui.qt5.ui_webbrowser
4 participants
@nilupulmanodya @ReimarBauer @matrss @joernu76