Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import failure in mslib.msui.qt5.ui_webbrowser #2503

Closed
ReimarBauer opened this issue Sep 3, 2024 · 1 comment
Closed

import failure in mslib.msui.qt5.ui_webbrowser #2503

ReimarBauer opened this issue Sep 3, 2024 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ReimarBauer
Copy link
Member

ReimarBauer commented Sep 3, 2024

from PyQt5 import QtWebEngineWidgets
ImportError: cannot import name 'QtWebEngineWidgets' from 'PyQt5' (/home/reimarb/Miniforge/envs/mssdev/lib/python3.11/site-packages/PyQt5/__init__.py)
mamba list pyqt
# packages in environment at /home/reimarb/Miniforge/envs/mssdev:
#
# Name                    Version                   Build  Channel
pyqt                      5.15.9          py311hf0fb5b6_5    conda-forge
pyqt5-sip                 12.12.2         py311hb755f60_5    conda-forge
pyqtgraph                 0.13.4             pyhd8ed1ab_0    conda-forge

rebuilding from ui_webbrowser.ui still has the line
self.webEngineView = QtWebEngineWidgets.QWebEngineView(self.centralwidget)

and it is not imported

from PyQt5 import QtCore, QtGui, QtWidgets

QtWebKit was deprecated in Qt 5.5

@ReimarBauer ReimarBauer added this to the 9.2.1 milestone Sep 3, 2024
@ReimarBauer ReimarBauer added the bug Something isn't working label Sep 3, 2024
@matrss
Copy link
Collaborator

matrss commented Sep 3, 2024

Cross-linking #2293: the web browser code path is dead code (it is an example of such in that issue); as it is unused and there is no plan to start using it in the future I think it can just be removed.

This was referenced Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants