Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add destination_files to Push Workflow #81

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

xcskier56
Copy link

Pull request

Adding the destination_files option to the push workflow so that we can have files in the
destination repo that are not overwritten when a push from the SoT happens

Related issue

#80

Motivation and context

In our destination repo, we want to have certain files that are only contained in it and not overwritten when pushed to. Specifically we have different github actions in the destination repo vs the SoT repo and don't want them overwritten.

Solution

add destination_files = glob(PR_INCLUDE, exclude = PR_EXCLUDE), to the push workflow

How has this been tested

I used a custom copy.bara.sky file and ran it locally and verified that destination files were not overwritten

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the docs/CONTRIBUTING.md document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Adding the destination_files option to the push workflow so that we can have files in the
destination repo that are *not* overwritten when a push from the SoT happens
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant