Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add destination_files to push to not overwrite certain files in Destination repo #80

Open
xcskier56 opened this issue Dec 27, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@xcskier56
Copy link

💡 Feature proposal

Use-cases

In our destination repo, we want to have certain files that are only contained in it and not overwritten when pushed to. Specifically we have different github actions in the destination repo vs the SoT repo and don't want them overwritten.

Attempted solutions

I have already added pr_exludes to the github action config and it does not seem to be working. The other solution would be to just use our completely custom copy.bara.sky file, but that removes a lot of the magic of this code that is very nice.

Proposal

add destination_files = glob(PR_INCLUDE, exclude = PR_EXCLUDE), to the push workflow

@xcskier56 xcskier56 added the enhancement New feature or request label Dec 27, 2021
@zubeyiro
Copy link

hey @xcskier56 any plans of merging this PR?

@xcskier56
Copy link
Author

Wow, I totally forgot that this PR was open. We aren't using this workflow anymore so I don't need it, but happy to make any changes to the PR that you'd like me to

@zubeyiro
Copy link

PR is fine, Ive forked this repo and applied PR already: https://github.com/mailchain/copybara-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants