Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to the system-provided version of octomap. #46

Merged

Conversation

clalancette
Copy link

This ensures that we have a consistent ABI between this package and any other packages in the system that use it. We'll eventually be removing the ROS-provided octomap package to ensure we don't run into future problems.

This was enabled by the merging of ros/rosdistro#41623

This ensures that we have a consistent ABI between this
package and any other packages in the system that use it.
We'll eventually be removing the ROS-provided octomap
package to ensure we don't run into future problems.

Signed-off-by: Chris Lalancette <[email protected]>
@clalancette
Copy link
Author

Friendly ping here; we are going to remove the octomap package from Rolling soon, which means this package will then fail to build without this patch.

@wxmerkt wxmerkt closed this Jul 2, 2024
@wxmerkt wxmerkt reopened this Jul 2, 2024
@wxmerkt wxmerkt merged commit a38b890 into OctoMap:ros2 Jul 2, 2024
4 of 16 checks passed
@wxmerkt
Copy link
Member

wxmerkt commented Jul 2, 2024

Thank you!

@clalancette clalancette deleted the clalancette/switch-to-system-octomap branch July 2, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants