Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p: invert relay address routing #991

Merged
merged 2 commits into from
Aug 18, 2022
Merged

p2p: invert relay address routing #991

merged 2 commits into from
Aug 18, 2022

Conversation

corverroos
Copy link
Contributor

@corverroos corverroos commented Aug 18, 2022

Inverts relay address routing from pull based to pull based.

category: refactor
ticket: #989
feature_flag: invert_libp2p_routing

@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #991 (ce77481) into main (a68a2c6) will increase coverage by 0.26%.
The diff coverage is 13.04%.

@@            Coverage Diff             @@
##             main     #991      +/-   ##
==========================================
+ Coverage   53.91%   54.17%   +0.26%     
==========================================
  Files         117      117              
  Lines       12994    13022      +28     
==========================================
+ Hits         7006     7055      +49     
+ Misses       4971     4944      -27     
- Partials     1017     1023       +6     
Impacted Files Coverage Δ
app/featureset/featureset.go 100.00% <ø> (ø)
app/lifecycle/orderstart_string.go 40.00% <ø> (ø)
p2p/discovery.go 30.90% <0.00%> (+0.27%) ⬆️
p2p/relay.go 0.00% <0.00%> (ø)
p2p/p2p.go 22.30% <30.76%> (+1.28%) ⬆️
app/app.go 57.25% <100.00%> (+0.08%) ⬆️
core/aggsigdb/memory.go 79.62% <0.00%> (-0.93%) ⬇️
core/qbft/qbft.go 81.11% <0.00%> (+10.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Aug 18, 2022
@obol-bulldozer obol-bulldozer bot merged commit e9241bf into main Aug 18, 2022
@obol-bulldozer obol-bulldozer bot deleted the corver/relaypush branch August 18, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants