p2p: invert peer discovery integration #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corverroos
commented
Aug 17, 2022
Comment on lines
-31
to
-35
| // UDPNode wraps a discv5 udp node and adds the bootnodes relays. | ||
| type UDPNode struct { | ||
| *discover.UDPv5 | ||
| Relays []Peer | ||
| } |
corverroos
commented
Aug 17, 2022
| @@ -71,7 +71,7 @@ func TestP2PConnGating(t *testing.T) { | |||
|
|
|||
| err = nodeA.Connect(context.Background(), addr) | |||
| require.Error(t, err) | |||
| require.Contains(t, err.Error(), fmt.Sprintf("gater rejected connection with peer %s and addr %s", addr.ID, addr.Addrs[0])) | |||
There was a problem hiding this comment.
flapping test, somehow used ipv6 on my local machine
Codecov Report
@@ Coverage Diff @@
## main #989 +/- ##
==========================================
- Coverage 54.44% 54.29% -0.16%
==========================================
Files 117 117
Lines 12954 12994 +40
==========================================
+ Hits 7053 7055 +2
- Misses 4879 4916 +37
- Partials 1022 1023 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
xenowits
reviewed
Aug 17, 2022
| @@ -133,3 +137,62 @@ func NewLocalEnode(config Config, key *ecdsa.PrivateKey) (*enode.LocalNode, *eno | |||
|
|
|||
| return node, db, nil | |||
| } | |||
|
|
|||
| // NewDiscoveryAdapter returns a life cycle hook that links discv5 to libp2p by | |||
| // continuously polling discv5 for latest peer ERNs and adding then to libp2p peer store. | |||
There was a problem hiding this comment.
Suggested change
| // continuously polling discv5 for latest peer ERNs and adding then to libp2p peer store. | |
| // continuously polling discv5 for latest peer ENRs and adding then to libp2p peer store. |
xenowits
reviewed
Aug 17, 2022
| ctx = log.WithTopic(ctx, "p2p") | ||
| ttl := peerstore.TempAddrTTL | ||
| baseDelay := expbackoff.WithBaseDelay(time.Millisecond * 100) // Poll quickly on startup | ||
| maxDelay := expbackoff.WithMaxDelay(ttl * 9 / 10) // Slow down to 90% of ttl |
There was a problem hiding this comment.
nit:
Suggested change
| maxDelay := expbackoff.WithMaxDelay(ttl * 9 / 10) // Slow down to 90% of ttl | |
| maxDelay := expbackoff.WithMaxDelay(ttl * 0.9) // Slow down to 90% of ttl |
corverroos
added
the
merge when ready
obol-bulldozer bot
pushed a commit
that referenced
this pull request
Aug 18, 2022
Inverts relay address routing from pull based to pull based. category: refactor ticket: #989 feature_flag: invert_libp2p_routing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inverts the integration between discv5 and libp2p from pull to push.
category: refactor
ticket: #985
feature_flag: invert_discv5