app/eth2wrap: implement eth2 wrapper for metrics and errors #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corverroos
commented
Apr 5, 2022
| } | ||
| ) | ||
|
|
||
| func main() { |
corverroos
commented
Apr 5, 2022
core/eth2metrics/metrics_gen.go
Outdated
|
|
||
| package eth2metrics | ||
|
|
||
| // Code generated by genmetrics.go. DO NOT EDIT. |
There was a problem hiding this comment.
resulting generated code
corverroos
force-pushed
the
corver/metriceth2
branch
from
d8fce48
to
74c9c6b
Compare
|
@corverroos verify pr check is not working it seems. |
corverroos
changed the title
corverroos
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
app/eth2wrappackage the contains aServicetype that wrapseth2http.Serviceby adding prometheus metrics and error wrapping (for proper stack traces). It uses code generation.category: feature
ticket: #362