Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prometheus metrics for beacon node requests #362

Closed
corverroos opened this issue Apr 6, 2022 · 0 comments
Closed

Add prometheus metrics for beacon node requests #362

corverroos opened this issue Apr 6, 2022 · 0 comments
Assignees
@corverroos
Labels
enhancement New feature or request

Comments

@corverroos
Copy link
Contributor

corverroos commented Apr 6, 2022 •
edited
Loading

Problem to be solved

Our eth2http beacon node API client doesn't provide any metrics.

Proposed solution

Implement a wrapper in app/eth2wrap for eth2http.Service that wraps all methods adding prometheus metrics (latency and errors) as well as error wrapping (for proper stack traces).

Skip cached methods.

Preferably generate the wrapper so changes and updates are easy.
@corverroos corverroos added the enhancement New feature or request label Apr 6, 2022
@corverroos corverroos self-assigned this Apr 6, 2022
@corverroos corverroos mentioned this issue Apr 6, 2022
Merged
obol-bulldozer bot pushed a commit that referenced this issue Apr 6, 2022
@corverroos
app/eth2wrap: implement eth2 wrapper for metrics and errors (#359)
85c04cf 
Add a `app/eth2wrap` package the contains a `Service` type that wraps `eth2http.Service` by adding prometheus metrics and error wrapping (for proper stack traces). It uses code generation.

category: feature
ticket: #362
@corverroos corverroos mentioned this issue Apr 6, 2022
Merged
obol-bulldozer bot pushed a commit that referenced this issue Apr 6, 2022
@corverroos
app/eth2wrap: fix metric namespace (#377)
3a26858 
Fixes prometheus namespaces for eth2wrap metrics.

category: bug
ticket: #362
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corverroos corverroos

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@corverroos