Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: cherry pick commits #2696

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Conversation

xenowits
Copy link
Contributor

@xenowits xenowits commented Nov 9, 2023

CHERRY-PICKED PRs

category: bug
ticket: none

Continue looking for signed beacon blocks if a block for a given slot is not found when proposing synthetic blocks.

This solves recurrent logs when synthetic block proposal feature is switched on:
```
{"code":404,"message":"NOT_FOUND: beacon block at slot 6916888","stacktraces":[]}
```

category: bug 
ticket: none
@xenowits xenowits self-assigned this Nov 9, 2023
@github-actions github-actions bot added the branch-release PR or Issue linked to a release branch (not main) label Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (3b701cb) 53.27% compared to head (9591236) 53.17%.

❗ Current head 9591236 differs from pull request most recent head b18c214. Consider uploading reports for the commit b18c214 to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##           main-v0.18    #2696      +/-   ##
==============================================
- Coverage       53.27%   53.17%   -0.11%     
==============================================
  Files             201      201              
  Lines           27574    27576       +2     
==============================================
- Hits            14691    14664      -27     
- Misses          11068    11095      +27     
- Partials         1815     1817       +2     
Files Coverage Δ
app/obolapi/api.go 66.10% <100.00%> (+0.58%) ⬆️
app/eth2wrap/synthproposer.go 62.93% <25.00%> (-0.19%) ⬇️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dB2510 dB2510 changed the title eth2wrap: fix synthetic block proposals (#2693) eth2wrap: fix synthetic block proposals Nov 9, 2023
Update timeout to 30s for publishing lock to obol-api. This ensures that DKG doesn't error if lock files are large enough (>200kb) whose publishing takes more than 5s. 

30s is an empirical timeout value which is safe for publishing large lock files (1.5MB)  to obol-api.

category: refactor 
ticket: none
@xenowits xenowits requested review from dB2510 and gsora November 9, 2023 10:34
@gsora
Copy link
Collaborator

gsora commented Nov 9, 2023

Does this PR fixes #2695?

@xenowits xenowits changed the title eth2wrap: fix synthetic block proposals *: cherry pick commits Nov 9, 2023
@xenowits
Copy link
Contributor Author

xenowits commented Nov 9, 2023

@gsora No, #2693 fixes #2695

This PR is a cherry-pick into the v0.18 release branch

Bump go version to `1.21.4`.

This resolves failing govulncheck in https://github.com/ObolNetwork/charon/actions/runs/6809276170/job/18515227544?pr=2693.

category: fixbuild
ticket: none
Copy link

sonarcloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@xenowits xenowits added the merge when ready Indicates bulldozer bot may merge when all checks pass label Nov 9, 2023
@obol-bulldozer obol-bulldozer bot merged commit ddf4d0a into main-v0.18 Nov 9, 2023
15 checks passed
@obol-bulldozer obol-bulldozer bot deleted the xenowits/cherry-synth-proposal branch November 9, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-release PR or Issue linked to a release branch (not main) merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants