eth2wrap: fix synthetic block proposals #2693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xenowits
changed the title
xenowits
commented
Nov 9, 2023
| return nil, err | ||
| } else if signed == nil { // go-eth2-client returns nil if proposal is not found. |
There was a problem hiding this comment.
This is not true anymore, ie, go-eth2-client no longer returns nil, nil
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2693 +/- ##
==========================================
+ Coverage 53.18% 53.29% +0.10%
==========================================
Files 201 201
Lines 27576 27577 +1
==========================================
+ Hits 14666 14696 +30
+ Misses 11093 11065 -28
+ Partials 1817 1816 -1
☔ View full report in Codecov by Sentry. |
|
dB2510
reviewed
Nov 9, 2023
Co-authored-by: Dhruv Bodani <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
dB2510
approved these changes
Nov 9, 2023
xenowits
added
the
merge when ready
xenowits
added a commit
that referenced
this pull request
Nov 9, 2023
Continue looking for signed beacon blocks if a block for a given slot is not found when proposing synthetic blocks.
This solves recurrent logs when synthetic block proposal feature is switched on:
```
{"code":404,"message":"NOT_FOUND: beacon block at slot 6916888","stacktraces":[]}
```
category: bug
ticket: none
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue looking for signed beacon blocks if a block for a given slot is not found when proposing synthetic blocks.
This solves recurrent logs when synthetic block proposal feature is switched on:
category: bug
ticket: #2695