cmd/combine: allow threshold number of keys to combine #2664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2664 +/- ##
==========================================
- Coverage 53.27% 53.21% -0.07%
==========================================
Files 202 202
Lines 27517 27517
==========================================
- Hits 14661 14643 -18
- Misses 11005 11028 +23
+ Partials 1851 1846 -5
☔ View full report in Codecov by Sentry. |
xenowits
reviewed
Oct 27, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
xenowits
approved these changes
Oct 30, 2023
xenowits
added
the
merge when ready
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows threshold number of keys to combine private keyshares into single validator keystore.
category: refactor
ticket: #2663