Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement a threshold-based recombination #2663

Closed
3 tasks
boulder225 opened this issue Oct 27, 2023 · 1 comment
Closed
3 tasks

implement a threshold-based recombination #2663

boulder225 opened this issue Oct 27, 2023 · 1 comment
Assignees
Labels
protocol Protocol Team tickets v0.18.0

Comments

@boulder225
Copy link

🎯 Problem to be solved

The current key recombining process requires all key shares to be present, contradicting the resilience feature of DVT as suggested in the docs. The CLI reference mentions all key shares need to be present.

09:11:50.294 ERRO cmd Fatal error: not all private key shares found for validator {"validator_index": 0, "expected": 4, "actual": 3}

🛠️ Proposed solution

  • Research how to implement a threshold-based recombination instead of requiring all key shares.
  • Conduct a risk assessment to weigh the trade-offs between resilience and the potential for collusion.
  • Update documentation to reflect any changes made.
@github-actions github-actions bot added the protocol Protocol Team tickets label Oct 27, 2023
@dB2510 dB2510 self-assigned this Oct 27, 2023
obol-bulldozer bot pushed a commit that referenced this issue Oct 30, 2023
Allows threshold number of keys to combine private keyshares into single validator keystore.

category: refactor
ticket: #2663
@dB2510
Copy link
Contributor

dB2510 commented Oct 31, 2023

Closed by #2664

@dB2510 dB2510 closed this as completed Oct 31, 2023
@dB2510 dB2510 added the v0.18.0 label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol Protocol Team tickets v0.18.0
Projects
None yet
Development

No branches or pull requests

2 participants