Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth2util: add holesky #2628

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Conversation

dB2510
Copy link
Contributor

@dB2510 dB2510 commented Oct 9, 2023

Add holesky to the list of supported networks.

Cherry-pick: #2590

category: feature
ticket: #2399

Add `holesky` to the list of supported networks.

category: feature 
ticket: #2399
@github-actions github-actions bot added the branch-release PR or Issue linked to a release branch (not main) label Oct 9, 2023
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a85f27f) 53.68% compared to head (c8cab1f) 53.72%.
Report is 1 commits behind head on main-v0.17.

Additional details and impacted files
@@              Coverage Diff               @@
##           main-v0.17    #2628      +/-   ##
==============================================
+ Coverage       53.68%   53.72%   +0.04%     
==============================================
  Files             198      198              
  Lines           26931    26946      +15     
==============================================
+ Hits            14458    14478      +20     
+ Misses          10671    10666       -5     
  Partials         1802     1802              
Files Coverage Δ
cmd/createdkg.go 72.58% <100.00%> (ø)
eth2util/network.go 67.39% <ø> (ø)
cmd/createcluster.go 59.82% <0.00%> (ø)

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dB2510 dB2510 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Oct 9, 2023
@obol-bulldozer obol-bulldozer bot merged commit 36e5445 into main-v0.17 Oct 9, 2023
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the dhruv/cherrypickaddholesky branch October 9, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-release PR or Issue linked to a release branch (not main) merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants