Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add holesky fork version to charon #2399

Closed
3 tasks
LukeHackett12 opened this issue Jul 5, 2023 · 2 comments
Closed
3 tasks

Add holesky fork version to charon #2399

LukeHackett12 opened this issue Jul 5, 2023 · 2 comments
Assignees
Labels
protocol Protocol Team tickets

Comments

@LukeHackett12
Copy link
Contributor

LukeHackett12 commented Jul 5, 2023

🎯 Problem to be solved

Charon will need to be able to support Holesky testnet when it is released.

🛠️ Proposed solution

Once the Holesky fork version and genesis timestamp are known, add a new network var here and add it to supported networks.

	Holesky = Network{
		ChainID: 17000,
		Name: "holesky",
		GenesisForkVersionHex: "0x00017000",
		GenesisTimestamp: 1694786400,
	}

Also enable --network=holesky as an option for create dkg & create cluster commands.

🧪 Tests

  • Tested by new automated unit/integration/smoke tests
  • Manually tested on core team/canary/test clusters
  • Manually tested on local compose simnet
@github-actions github-actions bot added the protocol Protocol Team tickets label Jul 5, 2023
@LukeHackett12
Copy link
Contributor Author

@OisinKyne
Copy link
Contributor

Looks like the params have been added, including the extradata being removed https://github.com/eth-clients/holesky

obol-bulldozer bot pushed a commit that referenced this issue Sep 20, 2023
Add `holesky` to the list of supported networks.

category: feature 
ticket: #2399
dB2510 pushed a commit that referenced this issue Oct 9, 2023
Add `holesky` to the list of supported networks.

category: feature 
ticket: #2399
obol-bulldozer bot pushed a commit that referenced this issue Oct 9, 2023
Add `holesky` to the list of supported networks.

Cherry-pick: #2590 

category: feature 
ticket: #2399
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol Protocol Team tickets
Projects
None yet
Development

No branches or pull requests

4 participants