Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd: fix create cluster regression #2445

Merged
merged 5 commits into from
Jul 26, 2023
Merged

cmd: fix create cluster regression #2445

merged 5 commits into from
Jul 26, 2023

Commits on Jul 18, 2023

  1. cmd: fix create cluster regression 

    After the `create cluster` refactor a couple PR's back, definition file was essentially ignored.

This PR restores that functionality back,
    @gsora
    gsora committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    8e2fa93 View commit details
    Browse the repository at this point in the history

  2. address review comments

    @gsora
    gsora committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    9e1c6d2 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. address review comments

    @gsora
    gsora committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    1bdead6 View commit details
    Browse the repository at this point in the history

  2. add comment explaining why we're setting conf.NumDVs in splitkeys flow

    @gsora
    gsora committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    bfbcfa3 View commit details
    Browse the repository at this point in the history

  3. use definition instead of config as much as possible, handle edge cas… 

    …e of splitkeys with definition and mismatching amount of validators
    @gsora
    gsora committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    e9e090c View commit details
    Browse the repository at this point in the history