-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd: fix create cluster
regression
#2445
Conversation
After the `create cluster` refactor a couple PR's back, definition file was essentially ignored. This PR restores that functionality back,
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2445 +/- ##
==========================================
+ Coverage 53.72% 53.79% +0.06%
==========================================
Files 198 198
Lines 26478 26502 +24
==========================================
+ Hits 14226 14256 +30
+ Misses 10490 10483 -7
- Partials 1762 1763 +1
☔ View full report in Codecov by Sentry. |
cmd/createcluster.go
Outdated
@@ -152,22 +147,30 @@ func runCreateCluster(ctx context.Context, w io.Writer, conf clusterConfig) erro | |||
if err != nil { | |||
return err | |||
} | |||
|
|||
conf.FeeRecipientAddrs = def.FeeRecipientAddresses() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it feels like definition is the source of truth from this point, why is it required to update the config? The else statement creates a definition from the config, feels like we should just use definition from this point forward
…e of splitkeys with definition and mismatching amount of validators
After the
create cluster
refactor a couple PR's back, definition file was essentially ignored.This PR restores that functionality back.
category: bug
ticket: #2444
Closes #2444