Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: fix create cluster regression #2445

Merged
merged 5 commits into from
Jul 26, 2023

Conversation

gsora
Copy link
Collaborator

@gsora gsora commented Jul 18, 2023

After the create cluster refactor a couple PR's back, definition file was essentially ignored.

This PR restores that functionality back.

category: bug
ticket: #2444

Closes #2444

After the `create cluster` refactor a couple PR's back, definition file was essentially ignored.

This PR restores that functionality back,
@gsora gsora self-assigned this Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 88.23% and project coverage change: +0.06 🎉

Comparison is base (55c4c45) 53.72% compared to head (e9e090c) 53.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2445      +/-   ##
==========================================
+ Coverage   53.72%   53.79%   +0.06%     
==========================================
  Files         198      198              
  Lines       26478    26502      +24     
==========================================
+ Hits        14226    14256      +30     
+ Misses      10490    10483       -7     
- Partials     1762     1763       +1     
Impacted Files Coverage Δ
cmd/createcluster.go 60.05% <88.23%> (-0.24%) ⬇️

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

cmd/createcluster.go Outdated Show resolved Hide resolved
@gsora gsora requested a review from corverroos July 18, 2023 14:46
cmd/createcluster.go Outdated Show resolved Hide resolved
@@ -152,22 +147,30 @@ func runCreateCluster(ctx context.Context, w io.Writer, conf clusterConfig) erro
if err != nil {
return err
}

conf.FeeRecipientAddrs = def.FeeRecipientAddresses()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it feels like definition is the source of truth from this point, why is it required to update the config? The else statement creates a definition from the config, feels like we should just use definition from this point forward

@gsora gsora requested a review from corverroos July 25, 2023 13:33
@gsora gsora added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jul 26, 2023
@obol-bulldozer obol-bulldozer bot merged commit dc84c66 into main Jul 26, 2023
@obol-bulldozer obol-bulldozer bot deleted the gsora/createcluster_definition_fix branch July 26, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing flags error on create cluster command
2 participants