Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p: revert #2350 #2383

Merged
merged 1 commit into from
Jun 30, 2023
Merged

p2p: revert #2350 #2383

merged 1 commit into from
Jun 30, 2023

Conversation

dB2510
Copy link
Contributor

@dB2510 dB2510 commented Jun 30, 2023

Reverts #2350

category: refactor
ticket: #1934

@dB2510 dB2510 changed the title p2p: Revert "remove support for legacy stream delimited protocols" p2p: Revert #2350 Jun 30, 2023
@dB2510 dB2510 changed the title p2p: Revert #2350 p2p: revert #2350 Jun 30, 2023
@dB2510 dB2510 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jun 30, 2023
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Patch coverage: 72.91% and project coverage change: +0.02 🎉

Comparison is base (67e0c0d) 53.61% compared to head (43389bc) 53.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2383      +/-   ##
==========================================
+ Coverage   53.61%   53.63%   +0.02%     
==========================================
  Files         192      192              
  Lines       25933    25961      +28     
==========================================
+ Hits        13903    13925      +22     
- Misses      10305    10314       +9     
+ Partials     1725     1722       -3     
Impacted Files Coverage Δ
dkg/bcast/server.go 70.42% <ø> (ø)
core/parsigex/parsigex.go 62.79% <33.33%> (ø)
core/consensus/component.go 65.81% <50.00%> (ø)
p2p/sender.go 74.86% <68.96%> (+0.51%) ⬆️
app/peerinfo/peerinfo.go 68.88% <75.00%> (ø)
app/peerinfo/adhoc.go 76.92% <100.00%> (ø)
core/consensus/transport.go 70.58% <100.00%> (+0.21%) ⬆️
core/priority/prioritiser.go 62.79% <100.00%> (+3.25%) ⬆️
dkg/bcast/client.go 81.25% <100.00%> (ø)
dkg/frostp2p.go 75.30% <100.00%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@obol-bulldozer obol-bulldozer bot merged commit 11f2b74 into main Jun 30, 2023
@obol-bulldozer obol-bulldozer bot deleted the revert-2350-corver/removedelim branch June 30, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants