Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for stream-delimited wire protocols #1934

Closed
corverroos opened this issue Mar 27, 2023 · 1 comment
Closed

Remove support for stream-delimited wire protocols #1934

corverroos opened this issue Mar 27, 2023 · 1 comment
Labels
protocol Protocol Team tickets

Comments

@corverroos
Copy link
Contributor

corverroos commented Mar 27, 2023 •
edited
Loading

🎯 Problem to be solved

We are migrating libp2p to length-delimited wire protocols, see #1884. v0.16 supports both stream AND length delimited protocols.

The need to complete the migration after the v0.16 release by removing support for stream-delimited protocols (and thereby v0.15).
@github-actions github-actions bot added the protocol Protocol Team tickets label Mar 27, 2023
@corverroos corverroos mentioned this issue Mar 28, 2023
Merged
@corverroos corverroos reopened this May 19, 2023
@corverroos
Copy link
Contributor Author

Reopening since this needs to be done in v0.17.0

@corverroos corverroos mentioned this issue Jun 22, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this issue Jun 22, 2023
@corverroos
p2p: remove support for legacy stream delimited protocols (#2350)
7374a44 
Removes support for legacy stream delimited libp2p protocols. Only support length-delimited protocols.

category: refactor
ticket: #1934
xenowits pushed a commit that referenced this issue Jun 26, 2023
@corverroos @xenowits
p2p: remove support for legacy stream delimited protocols (#2350)
cf3cf3a 
Removes support for legacy stream delimited libp2p protocols. Only support length-delimited protocols.

category: refactor
ticket: #1934
@dB2510 dB2510 mentioned this issue Jun 30, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this issue Jun 30, 2023
@dB2510
p2p: revert #2350 (#2383)
11f2b74 
Reverts #2350 

category: refactor
ticket: #1934
@dB2510 dB2510 mentioned this issue Aug 1, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this issue Aug 1, 2023
@dB2510
p2p: remove support for legacy stream delimited protocols (#2495)
7d3fb56 
Removes support for legacy stream delimited libp2p protocols. Only support length-delimited protocols.
Note: this PR is clone of #2350 

category: refactor
ticket: #1934
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
protocol Protocol Team tickets
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@corverroos