Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: add p2p stream metric and disable resource manager #2291

Merged
merged 3 commits into from
Jun 8, 2023

Conversation

corverroos
Copy link
Contributor

dB2510 and others added 3 commits June 8, 2023 11:25
Disable resource manager in charon to avoid `resource limit exceeded` error from libp2p.

category: misc
ticket: #2277
Adds a Prometheus metric to track the opened streams by protocol.

category: bug
ticket: #2277
Implement a ResetGauge to simplify "resetting of previously set labels".

category: misc
ticket: #2277
@github-actions github-actions bot added the branch-release PR or Issue linked to a release branch (not main) label Jun 8, 2023
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage: 39.68% and project coverage change: -0.01 ⚠️

Comparison is base (496020d) 53.77% compared to head (a57c120) 53.76%.

Additional details and impacted files
@@              Coverage Diff               @@
##           main-v0.16    #2291      +/-   ##
==============================================
- Coverage       53.77%   53.76%   -0.01%     
==============================================
  Files             188      189       +1     
  Lines           25536    25590      +54     
==============================================
+ Hits            13731    13758      +27     
- Misses          10123    10143      +20     
- Partials         1682     1689       +7     
Impacted Files Coverage Δ
app/app.go 6.93% <0.00%> (-0.04%) ⬇️
app/monitoringapi.go 50.57% <0.00%> (-0.59%) ⬇️
p2p/metrics.go 0.00% <ø> (ø)
p2p/p2p.go 20.52% <0.00%> (-2.02%) ⬇️
app/promauto/resetgauge.go 91.30% <91.30%> (ø)
app/peerinfo/peerinfo.go 70.06% <100.00%> (+0.20%) ⬆️
cmd/relay/p2p.go 38.46% <100.00%> (ø)
core/scheduler/metrics.go 82.35% <100.00%> (+1.10%) ⬆️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jun 8, 2023
@obol-bulldozer obol-bulldozer bot merged commit 6e448fe into main-v0.16 Jun 8, 2023
@obol-bulldozer obol-bulldozer bot deleted the corver/mainrcmgr branch June 8, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-release PR or Issue linked to a release branch (not main) merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants