Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app/promauto: implement reset gauge #2289

Merged
merged 3 commits into from
Jun 8, 2023
Merged

app/promauto: implement reset gauge #2289

merged 3 commits into from
Jun 8, 2023

Conversation

corverroos
Copy link
Contributor

@corverroos corverroos commented Jun 8, 2023

Implement a ResetGauge to simplify "resetting of previously set labels".

category: misc
ticket: #2277

@gsora
Copy link
Collaborator

gsora commented Jun 8, 2023

@corverroos CI is red because the metrics docs hasn't been updated, approved regardless because it looks fine otherwise

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jun 8, 2023
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage: 53.33% and project coverage change: +0.15 🎉

Comparison is base (ee11d1e) 53.67% compared to head (061a8af) 53.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2289      +/-   ##
==========================================
+ Coverage   53.67%   53.83%   +0.15%     
==========================================
  Files         190      191       +1     
  Lines       25628    25658      +30     
==========================================
+ Hits        13757    13814      +57     
+ Misses      10188    10161      -27     
  Partials     1683     1683              
Impacted Files Coverage Δ
app/monitoringapi.go 50.57% <0.00%> (-0.59%) ⬇️
p2p/metrics.go 0.00% <ø> (ø)
p2p/p2p.go 20.52% <0.00%> (-0.24%) ⬇️
app/promauto/resetgauge.go 91.30% <91.30%> (ø)
app/peerinfo/peerinfo.go 68.70% <100.00%> (-3.22%) ⬇️
core/scheduler/metrics.go 82.35% <100.00%> (+1.10%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@obol-bulldozer obol-bulldozer bot merged commit 7587507 into main Jun 8, 2023
@obol-bulldozer obol-bulldozer bot deleted the corver/resetgauge branch June 8, 2023 09:18
corverroos added a commit that referenced this pull request Jun 8, 2023
Implement a ResetGauge to simplify "resetting of previously set labels".

category: misc
ticket: #2277
obol-bulldozer bot pushed a commit that referenced this pull request Jun 8, 2023
Cherry picks the following PRs from main:
- #2278 
- #2289 
- #2290 

category: bug
ticket: #2277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants