Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/priority: refactor implementation #1433

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Conversation

corverroos
Copy link
Contributor

Refactor priority protocol implementation:

  • Align with consensus component architecture
  • Change instance to duty for improve compatibility and logging and simplicity.
  • Control priority instance with single context, including consensus timeout.

category: refactor
ticket: #1429

@codecov
Copy link

codecov bot commented Nov 13, 2022

Codecov Report

Base: 53.00% // Head: 53.27% // Increases project coverage by +0.26% 🎉

Coverage data is based on head (86ffd51) compared to base (5e96c9d).
Patch coverage: 59.61% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1433      +/-   ##
==========================================
+ Coverage   53.00%   53.27%   +0.26%     
==========================================
  Files         148      148              
  Lines       18393    18348      -45     
==========================================
+ Hits         9750     9774      +24     
+ Misses       7291     7223      -68     
+ Partials     1352     1351       -1     
Impacted Files Coverage Δ
core/priority/component.go 0.00% <0.00%> (ø)
core/priority/calculate.go 69.62% <60.00%> (+1.28%) ⬆️
core/priority/prioritiser.go 61.80% <61.53%> (-2.54%) ⬇️
app/app.go 60.94% <83.33%> (-0.34%) ⬇️
app/vmock.go 73.05% <0.00%> (+0.51%) ⬆️
core/qbft/qbft.go 81.51% <0.00%> (+9.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Nov 14, 2022
@obol-bulldozer obol-bulldozer bot merged commit 32a6ae4 into main Nov 14, 2022
@obol-bulldozer obol-bulldozer bot deleted the corver/priorefactor branch November 14, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants