core/priority: refactor to fix deadlock #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 53.41% // Head: 53.47% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1429 +/- ##
==========================================
+ Coverage 53.41% 53.47% +0.05%
==========================================
Files 145 147 +2
Lines 18193 18349 +156
==========================================
+ Hits 9718 9812 +94
- Misses 7140 7187 +47
- Partials 1335 1350 +15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dB2510
approved these changes
Nov 11, 2022
core/priority/prioritiser.go
Outdated
| recv.Response <- other.Msg | ||
|
|
||
| recv.Response <- own // Response channel has capacity of 1. | ||
| recv.Response = nil // Mark channel as responded.. |
There was a problem hiding this comment.
why not close(recv.Response) to "Mark channel as responded"?
There was a problem hiding this comment.
I refactored the whole thing, should be more obvious now.
xenowits
approved these changes
Nov 11, 2022
corverroos
changed the title
corverroos
added
the
merge when ready
obol-bulldozer bot
pushed a commit
that referenced
this pull request
Nov 14, 2022
Refactor priority protocol implementation: - Align with consensus component architecture - Change instance to duty for improve compatibility and logging and simplicity. - Control priority instance with single context, including consensus timeout. category: refactor ticket: #1429
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor priority main processing goroutine to fix deadlock when own message is received after and before others.
category: bug
ticket: none