Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for direct connection to charon alpha test peers #3065

Open
boulder225 opened this issue May 2, 2024 · 1 comment
Open

Add test for direct connection to charon alpha test peers #3065

boulder225 opened this issue May 2, 2024 · 1 comment
Assignees
@KaloyanTanev
Labels
alpha network test protocol Protocol Team tickets

Comments

@boulder225
Copy link

boulder225 commented May 2, 2024 •
edited by KaloyanTanev
Loading

🎯 Problem to be solved

Add test for direct connection to charon alpha test peers

🛠️ Proposed solution

  • Add test that forces direct connection to peers
  • Spin up local relay and assure test passes with direct connection between 2 (or more) libp2p nodes connecting to it
@boulder225 boulder225 added alpha network test protocol Protocol Team tickets labels May 2, 2024
@boulder225 boulder225 changed the title Copy of improve the testing suite for test commands Add test for direct connection to charon alpha test peers May 2, 2024
@boulder225
Copy link
Author

Please add your planning poker estimate with Zenhub @KaloyanTanev

@KaloyanTanev KaloyanTanev mentioned this issue May 7, 2024
Merged
obol-bulldozer bot pushed a commit that referenced this issue May 14, 2024
@KaloyanTanev
cmd: alpha test peers - add direct connection test (#3073)
9c65c8d 
Adding test for direct connection between peers. This should also implicitly test if our NAT is open.

There is a separate ticket for unit testing for all peers tests, as there are more things to be improved on that side - there need to be couple of nodes spin up, with local relay, to be able to properly test the `testpeers.go` code. As soon as that is done, there will be better testing suite for that test case as well.

To try locally, a local relay needs to be spin up first (or expose your IP and port, however, the former is easier):
`./charon relay --p2p-tcp-address="0.0.0.0:9000" --p2p-advertise-private-addresses`
`./charon alpha test peers --enrs="enr:-Iu4QJyserRukhG0Vgi2csu7GjpHYUGufNEbZ8Q7ZBrcZUb0KqpL5QzHonkh1xxHlxatTxrIcX_IS5J3SEWR_sa0ptGAgmlkgnY0gmlwhH8AAAGJc2VjcDI1NmsxoQMAUgEqczOjevyculnUIofhCj0DkgJudErM7qCYIvIkzIN0Y3CCDhqDdWRwgg4u" --p2p-relays="http://127.0.0.1:3640" --p2p-tcp-address="127.0.0.1:9001" --load-test-duration=30s`

I have also included small refactor of the return statements, making it a bit more readable.

category: feature
ticket: #3065
@boulder225 boulder225 reopened this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KaloyanTanev KaloyanTanev

Labels
alpha network test protocol Protocol Team tickets
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KaloyanTanev @boulder225