cmd: alpha test peers - add direct connection test #3073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3073 +/- ##
==========================================
- Coverage 56.49% 56.43% -0.06%
==========================================
Files 208 208
Lines 29020 29026 +6
==========================================
- Hits 16395 16381 -14
- Misses 10805 10826 +21
+ Partials 1820 1819 -1 ☔ View full report in Codecov by Sentry. |
pinebit
approved these changes
May 8, 2024
KaloyanTanev
force-pushed
the
kalo/peers-test-direct-connection
branch
from
d513538
to
9f4f6db
Compare
KaloyanTanev
force-pushed
the
kalo/peers-test-direct-connection
branch
from
c0cac3e
to
65afd04
Compare
|
gsora
approved these changes
May 14, 2024
KaloyanTanev
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding test for direct connection between peers. This should also implicitly test if our NAT is open.
There is a separate ticket for unit testing for all peers tests, as there are more things to be improved on that side - there need to be couple of nodes spin up, with local relay, to be able to properly test the
testpeers.gocode. As soon as that is done, there will be better testing suite for that test case as well.To try locally, a local relay needs to be spin up first (or expose your IP and port, however, the former is easier):
./charon relay --p2p-tcp-address="0.0.0.0:9000" --p2p-advertise-private-addresses./charon alpha test peers --enrs="enr:-Iu4QJyserRukhG0Vgi2csu7GjpHYUGufNEbZ8Q7ZBrcZUb0KqpL5QzHonkh1xxHlxatTxrIcX_IS5J3SEWR_sa0ptGAgmlkgnY0gmlwhH8AAAGJc2VjcDI1NmsxoQMAUgEqczOjevyculnUIofhCj0DkgJudErM7qCYIvIkzIN0Y3CCDhqDdWRwgg4u" --p2p-relays="http://127.0.0.1:3640" --p2p-tcp-address="127.0.0.1:9001" --load-test-duration=30sI have also included small refactor of the return statements, making it a bit more readable.
category: feature
ticket: #3065