Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create new cluster lock version v1.8 #2728

Closed
1 of 3 tasks
xenowits opened this issue Nov 28, 2023 · 0 comments
Closed
1 of 3 tasks

create new cluster lock version v1.8 #2728

xenowits opened this issue Nov 28, 2023 · 0 comments
Assignees
Labels
protocol Protocol Team tickets

Comments

@xenowits
Copy link
Contributor

xenowits commented Nov 28, 2023

🎯 Problem to be solved

We want to add the partial deposits feature in charon.

Partial deposits is the feature where operators can create clusters with arbitrary validator deposit amounts (not necessarily 32ETH).

For example, an entity would like to create a validator with 3 partial deposit data files: 20ETH, 10ETH & 2 ETH. We don’t support this functionality now and only create full deposit data of 32ETH per validator.

🛠️ Proposed solution

  • Add a new version v1.8 for cluster locks.
  • Add a new field DepositAmounts to cluster definition (cluster/definition.go):
{
...
   "threshold":3,
   "deposit_amounts":[		<-- NEW
"200000000000",	// 20 ETH
"100000000000",	// 10 ETH
"20000000000"	// 02 ETH
],
   "validators":[
      {
         "fee_recipient_address":"0x52f...74d",
         "withdrawal_address":"0x818...2c4",		
      },
      {
         "fee_recipient_address":"0xeb9...a25",
         "withdrawal_address":"0x5fb...e7c",
      }
   ],
   "dkg_algorithm":"default"
...
}
  • See the constraints for the DepositAmounts field here.

🧪 Tests

  • Tested by new automated unit/integration/smoke tests
  • Manually tested on core team/canary/test clusters
  • Manually tested on local compose simnet
@github-actions github-actions bot added the protocol Protocol Team tickets label Nov 28, 2023
@xenowits xenowits changed the title Create new cluster lock version v1.8 create new cluster lock version v1.8 Nov 28, 2023
@pinebit pinebit self-assigned this Jan 29, 2024
obol-bulldozer bot pushed a commit that referenced this issue Jan 31, 2024
This PR enables writing of multiple deposit files in according with partial amount values.
Also, this enables v1.8.0 to be the default one.

category: feature
ticket: #2728
@xenowits xenowits closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol Protocol Team tickets
Projects
None yet
Development

No branches or pull requests

2 participants