Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test partial deposits flow in create cluster #2847

Closed
xenowits opened this issue Feb 1, 2024 · 1 comment
Closed

Test partial deposits flow in create cluster #2847

xenowits opened this issue Feb 1, 2024 · 1 comment
Assignees
Labels
protocol Protocol Team tickets

Comments

@xenowits
Copy link
Contributor

xenowits commented Feb 1, 2024

🎯 Problem to be solved

We have fully implemented the partial deposits feature under the create cluster command. As part of the implementation, we have ensured that only minimal changes are introduced so we can easily test this feature and gather proper feedback from our customers.

🛠️ Proposed solution

We now need to test the partial deposits feature. This includes:

  • Test if create cluster command properly creates correct cluster definitions
  • Write sufficient unit/integration tests to verify the whole flow
  • Manually create cluster and provide different inputs

🧪 Tests

None.

@github-actions github-actions bot added the protocol Protocol Team tickets label Feb 1, 2024
@pinebit
Copy link
Contributor

pinebit commented Feb 6, 2024

Validation works as expected:

$ charon create cluster --nodes 4 --network goerli --num-validators 1 --deposit-amounts=1,7,16,9 --fee-recipient-addresses=0xC730155a5F702B6bF3CaeCD2
5ebff9fB1b2a2B85 --withdrawal-addresses=0xC730155a5F702B6bF3CaeCD25ebff9fB1b2a2B85
13:03:05.430 ERRO cmd        Fatal error: sum of partial deposit amounts must sum up to 32ETH {"sum": 33000000000}

Proper partial amounts generate proper deposit files.

@xenowits xenowits closed this as completed Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol Protocol Team tickets
Projects
None yet
Development

No branches or pull requests

2 participants